[#3051] - bootstrap.js modifications
- Closed
- 26 Sep 2014
- Medium
- Build: master
- # 3051
I have no idea is this should be tagged as issue of feature request cause it affects both. This is more like a thing to discuss. The problem is that bootstrap.js was modified. It shouldn't be touched except updates.
Look at this situation. I'm creating commercial template and using build in bootstrap framework. Bootstrap dropdown plugin is used for drop down menus. Every works fine, just few modifications into menu and done. BUT.... When I click on menu item its submenu is opening and cursor is starting to blink and console shows that browser constantly receives event (hover). This is modification that was made to bootstrap dropdown plugin by one of joomla coders. This bug affects both back-and and front-end for every template using build in bootstrap library. This is one thing I did found in this library, how many things like this are there because of modifying working library? Of course I can load bootstrap from cdn. But when any of Joomla extensions will use some of bootstrap functions default Boostrap Framework will be load and I will end with duplicated libraries and possible conflicts.
Now what to do, reverse bootstrap to stock? Or maybe add to JHTML::_('bootstrap.framework') new parameter that will load stock bootstrap library and leave existing as it is (fast fix but also not the best). Or something else? Any suggestions?
There is no place to discuss about things like this so don't blame me if it is at wrong place :)
IIRC we hacked the JS file to work around a MooTools/jQuery incompatibility and to allow the hover menus to work a certain way.
Well, now menus are hover 30 times in a second. Well done :D Have you checked how Administration main menu behave when you open submenu and have cursor on main item? What was the problem with hover menu and where it was showing.
First is not related to menu. It is page title icons as far as I understand. It looks like this came from #1508. This is kinda strange to brake bootstrap to provide older functionality from older versions of Joomla. Sure, this can be a little confusing from version to version for a user but usually update comes with changes. Also this is strange that bootstrap was changed to fix template problems. I thought that we keep template things in templates. I'll try to work on this one on the weekend and will see if this can be archived without breaking bootstrap library.
| Category | ⇒ | External Library JavaScript |
After 7 months without update I am closing this issue.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
| Status | New | ⇒ | Closed |
zero-24
- | Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-26 15:36:16 |
| Labels |
Added:
?
|
||
Usually we leave those libraries untouched as much as possible.
I know we had to do some changes to that specific file because of some issues we had with it. The changes should all be marked with
JUIcomments.However I don't know the exact issues there were. I would have to check the logs if there is anything written
If there is a bug, feel free to open a ticket on our JoomlaCode tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103 and if you are able to fix it, create a PR here and reference the tracker item.