? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
24 Aug 2020

Pull Request for Issue # .

Summary of Changes

changes the trash icon in actions dropdown to "fas fa-trash"

Testing Instructions

apply pr.
inspect action dropdown "trash" icon.
verify icon class is "fas fa-trash"

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

none

avatar N6REJ N6REJ - open - 24 Aug 2020
avatar N6REJ N6REJ - change - 24 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2020
Category Layout Libraries
avatar N6REJ
N6REJ - comment - 24 Aug 2020
avatar toivo toivo - test_item - 25 Aug 2020 - Tested successfully
avatar toivo
toivo - comment - 25 Aug 2020

I have tested this item successfully on b2648c4

Tested successfully in Beta4-dev of 24 August.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.

avatar sandewt sandewt - test_item - 25 Aug 2020 - Tested successfully
avatar sandewt
sandewt - comment - 25 Aug 2020

I have tested this item successfully on b2648c4

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT

Tested links: see #30464
administrator/index.php?option=com_menus&view=items&menutype=0main-menu-blog
administrator/index.php?option=com_menus&view=items&menutype=mainmenu


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.

avatar alikon alikon - change - 25 Aug 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 25 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.

avatar N6REJ N6REJ - change - 25 Aug 2020
Labels Added: ?
avatar N6REJ N6REJ - change - 25 Aug 2020
Labels Added: ?
avatar hans2103 hans2103 - test_item - 25 Aug 2020 - Tested successfully
avatar hans2103
hans2103 - comment - 25 Aug 2020

I have tested this item successfully on 8028ea0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.

avatar hans2103
hans2103 - comment - 25 Aug 2020
avatar infograf768
infograf768 - comment - 25 Aug 2020

Restarted drone

avatar sandewt
sandewt - comment - 25 Aug 2020

Sorry, but if we take a closer look, we show that not all spaces are placed correctly yet, for example:
I don't know if the intention is to change it now? Or in another PR?

And so on..

[EDIT]

avatar hans2103
hans2103 - comment - 25 Aug 2020

@sandewt this can be fixed in #30470 where I would like to merge two identical JLayout files into one.

avatar sandewt sandewt - test_item - 25 Aug 2020 - Tested successfully
avatar sandewt
sandewt - comment - 25 Aug 2020

I have tested this item successfully on 8028ea0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.

c716c1b 26 Aug 2020 avatar N6REJ drone
avatar infograf768
infograf768 - comment - 26 Aug 2020

Restarted drone

avatar infograf768
infograf768 - comment - 26 Aug 2020

system-test-mysql still failing

 I trash article "Test Article"
   I am on page "/administrator/index.php?option=com_con..."
  [GET] http://localhost/test-install/administrator/index.php?option=com_content&view=articles
   I get config "timeout"
   I wait for element {"id":"filter_search"},90
   I get config "timeout"
   I wait for element {"id":"filter_search"},90
   I fill field {"id":"filter_search"},"Test Article"
   I click {"xpath":"//button[@aria-label='Search']"}
   I see "Test Article"
   I check all results 
  Selecting Checkall button
   I click toolbar button "Action"
   I wait 2
   I click toolbar button "trash"
  Screenshot and page source were saved into '/********/src/tests/Codeception/_output/' dir
 FAIL 
avatar N6REJ
N6REJ - comment - 27 Aug 2020

@richard67 @infograf768 drone passing now.

avatar infograf768 infograf768 - change - 28 Aug 2020
Status Ready to Commit Pending
avatar infograf768
infograf768 - comment - 28 Aug 2020

Back to Pending. This PR has to be tested again.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.

avatar sandewt sandewt - test_item - 29 Aug 2020 - Tested successfully
avatar sandewt
sandewt - comment - 29 Aug 2020

I have tested this item successfully on a2d4a66

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.

avatar Formatio-hippocampi Formatio-hippocampi - test_item - 31 Aug 2020 - Tested successfully
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 31 Aug 2020

I have tested this item successfully on a2d4a66


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.

avatar N6REJ
N6REJ - comment - 31 Aug 2020

closing since we've merged it #30470

avatar N6REJ N6REJ - change - 31 Aug 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-08-31 14:53:55
Closed_By N6REJ
Labels Removed: ?
avatar N6REJ N6REJ - close - 31 Aug 2020

Add a Comment

Login with GitHub to post a comment