Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30467] - [4.0] Replace filter.condition by filter.published in com_content

? ? Success

User tests: Successful: Unsuccessful:

avatar chmst
chmst
24 Aug 2020

Started here #30459 .

Summary of Changes

In com_content and related modules, filter.condition is used for filtering publishedm unpublished, archived, trashed data.
This might cause problems when 3rd party extension set filters for articles.
This PR sets back the name to filter.published in J3. It does not change the behavour in any way.

Testing Instructions

Testing is not as easy, as these filters are used in different ways. The test is successful, if nothing in Joomla frontend changes with the patch applied.

You should have some content i.e. testing sample data - categories and articles, some archived, some published, some unpublished and some trashed.
And you should have modules for every kind of articles.

Now check in the frontend: The modules must show only published articles. Your blogs should show only published articles.

avatar chmst chmst - open - 24 Aug 2020
avatar chmst chmst - change - 24 Aug 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2020
Category ⇒ Front End com_content Modules
avatar chmst chmst - change - 24 Aug 2020
Title
…
Replace filter.condition by filter.published in com_content
[4.0] Replace filter.condition by filter.published in com_content
avatar chmst chmst - edited - 24 Aug 2020
avatar chmst chmst - change - 25 Aug 2020
Labels Added: ?
avatar Formatio-hippocampi Formatio-hippocampi - test_item - 7 Sep 2020 - Tested successfully
avatar ghost
ghost - comment - 7 Sep 2020

I have tested this item ✅ successfully on 01c7762

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30467.

avatar Quy
Quy - comment - 7 Sep 2020

Remove?

joomla-cms/modules/mod_articles_latest/src/Helper/ArticlesLatestHelper.php

Line 69 in 54d78e9

$model->setState('filter.condition', 1);

See:

joomla-cms/modules/mod_articles_latest/src/Helper/ArticlesLatestHelper.php

Line 52 in 54d78e9

$model->setState('filter.published', 1);

avatar karo3 karo3 - test_item - 17 Oct 2020 - Tested successfully
avatar karo3
karo3 - comment - 17 Oct 2020

I have tested this item ✅ successfully on 01c7762

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30467.

avatar richard67
richard67 - comment - 17 Oct 2020

@chmst Could you check @Quy 's comment above? Thanks in advance.

avatar gostn gostn - test_item - 30 Oct 2020 - Tested successfully
avatar gostn gostn - test_item - 9 Nov 2020 - Not tested
avatar chmst
chmst - comment - 9 Nov 2020

@Quy could you please remove the "update request" label from this PR, as the requested changes are made in #31155?

avatar richard67 richard67 - change - 14 Nov 2020
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 14 Nov 2020

Previous test results are still valid since last commit was only a clean branch update => RTC.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30467.

avatar richard67 richard67 - alter_testresult - 14 Nov 2020 - karo3: Tested successfully
avatar richard67 richard67 - alter_testresult - 14 Nov 2020 - ghost: Tested successfully
avatar richard67
richard67 - comment - 14 Nov 2020

Good to be merged .. I just gave it a test, too.

avatar richard67 richard67 - change - 14 Nov 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-11-14 19:19:05
Closed_By ⇒ richard67
Labels Added: ?
avatar richard67 richard67 - close - 14 Nov 2020
avatar richard67 richard67 - merge - 14 Nov 2020
avatar richard67
richard67 - comment - 14 Nov 2020

Thanks!

Add a Comment

Login with GitHub to post a comment