Feeling Lucky
NPM Resource Changed
?
?
[#30428] - [4.0] Check if orderedby element is available in searchtools
- Fixed in Code Base
- 31 Aug 2020
- Medium
- Build: 4.0-dev
- # 30428
- Diff
- Digital-Peak:j4/fix/search
User tests: Successful: Unsuccessful:
Summary of Changes
Joomla 3 components do not have the new orderedBy element in the back end lists. If this element is not available then a Javascript error happens:
Uncaught TypeError: document.getElementById(...) is null
onBoot /media/system/js/searchtools.js:540
EventListener.handleEvent* /media/system/js/searchtools.js:553
<anonymous> /media/system/js/searchtools.js:554
This pr stabilizes by adding a check if the element exists.
Testing Instructions
- Remove the lines 110 - 114 in the file /administrator/components/com_content/tmpl/articles/default.php
- Go to /administrator/index.php?option=com_content&view=articles
Actual result BEFORE applying this Pull Request
Error happens as described above.
Expected result AFTER applying this Pull Request
No JS error.
Documentation Changes Required
Nothing as the new orderedby element is not required anymore. When the pr is not accepted, then the docs need an update of the new required element.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
richard67
- comment
- 21 Aug 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30428.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 21 Aug 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30428.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-31 15:29:34 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Removed:
?
|
||
zero-24
- comment
- 31 Aug 2020
Merging thanks!
I have tested this item✅ successfully on 00ba9a8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30428.