Feeling Lucky
?
?
[#30415] - [4.0] Remove coloring from icons
- Fixed in Code Base
- 19 Aug 2020
- Medium
- Build: 4.0-dev
- # 30415
- Diff
- SharkyKZ:j4/scss/icons
User tests: Successful: Unsuccessful:
Summary of Changes
Removes explicit colors from these two icons.
Testing Instructions
node build.js --compile-css required.
Add some icons somewhere. E.g.:
<span class="icon-featured"></span>
<span class="icon-search"></span>
<span class="icon-publish"></span>
<span class="icon-unpublish"></span>
Actual result BEFORE applying this Pull Request
icon-publish and icon-unpublish are invisible against white background.
Expected result AFTER applying this Pull Request
Icons are same color.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change Front End Templates (site) |
SharkyKZ
- comment
- 19 Aug 2020
Anywhere. This just makes that publish/unpublish icons get their color from text like any other icon.
Quy
- comment
- 19 Aug 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30415.
infograf768
- comment
- 19 Aug 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30415.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 19 Aug 2020
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30415.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-19 16:29:28 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
?
|
||
Can you post a screenshot of where it would show?
Asking because I just did 2 PRs concerning icons colors.