? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
19 Aug 2020

Same issue as #30411

Summary of Changes

Icon class fas fa-times needs text-danger color. Otherwise it displays as white on white/lightgrey

Testing Instructions

Click on Permissions column icon to get the debug manager for a specififc user.
Same for a specific group.

Actual result BEFORE applying this Pull Request

User

Screen Shot 2020-08-19 at 09 01 38

Group

group_times

Expected result AFTER applying this Pull Request

User

Screen Shot 2020-08-19 at 09 03 20

Group

Screen Shot 2020-08-19 at 09 04 05

avatar infograf768 infograf768 - open - 19 Aug 2020
avatar infograf768 infograf768 - change - 19 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2020
Category Administration com_users
avatar infograf768
infograf768 - comment - 19 Aug 2020

Note

Do we really need the $button variable?
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_users/tmpl/debuggroup/default.php#L62-L85

						<?php foreach ($this->actions as $action) : ?>
								<?php
								$name  = $action[0];
								$check = $item->checks[$name];
								if ($check === true) :
									$class  = 'text-success fas fa-check';
									$button = 'btn-success';
									$text   = Text::_('COM_USERS_DEBUG_EXPLICIT_ALLOW');
								elseif ($check === false) :
									$class  = 'text-danger fas fa-times';
									$button = 'btn-danger';
									$text   = Text::_('COM_USERS_DEBUG_EXPLICIT_DENY');
								elseif ($check === null) :
									$class  = 'text-danger fas fa-minus-circle';
									$button = 'btn-warning';
									$text   = Text::_('COM_USERS_DEBUG_IMPLICIT_DENY');
								else :
									$class  = '';
									$button = '';
									$text   = '';
								endif;
								?>
							<td class="text-center">
								<span class="<?php echo $class; ?>" aria-hidden="true"></span>
								<span class="sr-only"> <?php echo $text; ?></span>
							</td>
avatar ceford ceford - test_item - 19 Aug 2020 - Tested successfully
avatar ceford
ceford - comment - 19 Aug 2020

I have tested this item successfully on b6da810

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30414.

avatar Magnytu2
Magnytu2 - comment - 19 Aug 2020

Works fine for me.

avatar infograf768
infograf768 - comment - 19 Aug 2020
avatar Magnytu2 Magnytu2 - test_item - 19 Aug 2020 - Tested successfully
avatar Magnytu2
Magnytu2 - comment - 19 Aug 2020

I have tested this item successfully on b6da810

Works fine for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30414.

avatar infograf768 infograf768 - change - 19 Aug 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 19 Aug 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30414.

avatar Quy Quy - close - 19 Aug 2020
avatar Quy Quy - merge - 19 Aug 2020
avatar Quy Quy - change - 19 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-19 16:26:09
Closed_By Quy
Labels Added: ? ?
avatar Quy
Quy - comment - 19 Aug 2020

$button can be removed. Thanks.

avatar infograf768
infograf768 - comment - 19 Aug 2020

$button can be removed. Thanks.

For another pr. looks like it is also useless in 3.x

Add a Comment

Login with GitHub to post a comment