[#30399] - [4.0] Remove unneeded strings from robots parameter
- Fixed in Code Base
- 18 Dec 2020
- Medium
- Build: 4.0-dev
- # 30399
- Diff
- Bakual:4_RemoveUnneededStrings
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Since we deprecated the strings in staging (#30110), this PR removes the strings in 4.0.
Summary of Changes
Removing unneeded strings
Testing Instructions
Nothing to test as the strings are not used anymore (after staging is merged up).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30399.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30399.
| Labels |
Added:
?
|
||
I've allowed myself to solve conflicts. After recent merge from 3.10-dev up to 4.0-dev, only components/com_content/forms/article.xml is remaining using the removed strings.
So we still have to wait for that one before we can merge this one here.
Looks certainly like I missed those for some reason.
That form file is used in the menuitem edit form in the backend. That's why the strings are missing in frontend.
@richard67 The file is there, I just created the PR to remove it.
I have no clue why I didn't see it back then, probably the same reason you're not seeing it today
Looks like, yes. Sorry for that.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-18 03:01:19 |
| Closed_By | ⇒ | wilsonge |
Can confirm nothing is using them after my latest set of merges
I have tested this item✅ successfully on 694d77f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30399.