Joomla! Issue Tracker | Joomla! CMS #30398 - [4.0] 2FA not enabled correctly when using link in post install message

Closed
19 Aug 2020
Medium
Build: staging
# 30398

PhilETaylor
17 Aug 2020

Steps to reproduce the issue

Install Joomla 4.0-dev
Login
Visit Post Installlation Messages
Click Enable two factor authentication button

EDIT: ENABLE YOUR JOOMLA CACHE in Joomla Global Config

Go to plugins and note that the plugins ARE ENABLED

Go to your User Menu -> Edit Account

Expected result

Two Factory Authentication Tab available

Actual result

No Two Factory Authentication Tab available

HOWEVER, then go and edit and SAVE (with no changes) the 2fa plugins again, then the tab will be available.

Im guessing the SQL that the "Enable two factor authentication" button runs is not setting all fields in the db correctly - is this a null issue again?

PhilETaylor - open - 17 Aug 2020

joomla-cms-bot - change - 17 Aug 2020

Labels

Added: ?

joomla-cms-bot - labeled - 17 Aug 2020

SharkyKZ - comment - 18 Aug 2020

I can't reproduce the issue. The query only updates one column. I don't see how null values could be an issue here:

joomla-cms/plugins/twofactorauth/totp/postinstall/actions.php

Lines 54 to 60 in 0ebb8a6

    
           $query = $db->getQuery(true) 
        
           	->update($db->quoteName('#__extensions')) 
        
           	->set($db->quoteName('enabled') . ' = ' . $db->quote(1)) 
        
           	->where($db->quoteName('type') . ' = ' . $db->quote('plugin')) 
        
           	->where($db->quoteName('folder') . ' = ' . $db->quote('twofactorauth')); 
        
           $db->setQuery($query); 
        
           $db->execute();

alikon - comment - 18 Aug 2020

the only thing which could be wrong is that the enabled field is declare as

`enabled` tinyint(3) NOT NULL DEFAULT 0,

https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/sql/mysql/base.sql#L121

->set($db->quoteName('enabled') . ' = ' . $db->quote(1))

should be

->set($db->quoteName('enabled') . ' = 1')

PhilETaylor - comment - 18 Aug 2020

Enable Joomla Cache. Test again. = Broken.

Its a caching issue. The cache needs flushing after the enabled is changed - else it doesn't show the tab

PhilETaylor - change - 18 Aug 2020

The description was changed

PhilETaylor - edited - 18 Aug 2020

alikon - change - 19 Aug 2020

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2020-08-19 08:36:55
Closed_By		⇒	alikon

alikon - close - 19 Aug 2020

alikon - comment - 19 Aug 2020

please test #30416

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#30398] - [4.0] 2FA not enabled correctly when using link in post install message

Steps to reproduce the issue

Expected result

Actual result

Add a Comment

	$query = $db->getQuery(true)
	->update($db->quoteName('#__extensions'))
	->set($db->quoteName('enabled') . ' = ' . $db->quote(1))
	->where($db->quoteName('type') . ' = ' . $db->quote('plugin'))
	->where($db->quoteName('folder') . ' = ' . $db->quote('twofactorauth'));
	$db->setQuery($query);
	$db->execute();