Feeling Lucky
?
NPM Resource Changed
?
?
[#30359] - [4.0][WIP][RFC] Child templates part 2: com_templates
- Closed
- 1 Apr 2021
- Medium
- Build: 4.0-dev
- Draft PR
- # 30359
- Diff
- dgrammatiko:4.0-dev-com_templates
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success Download Prebuilt packages are available for download. Details
- Failure continuous-integration/drone/pr Build is failing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This is still work in progress read the comments bellow
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Language & Strings JavaScript Repository NPM Change Libraries |
kawshar
- comment
- 13 Aug 2020
You are welcome to adopt anything from our concept. For Joomla :)
About the multiple views, we can easily merge both without breaking anything.
brianteeman
- comment
- 13 Aug 2020
Definitely in favour of merging the template views.
| Labels |
Added:
?
NPM Resource Changed
?
?
|
||
dgrammatiko
- comment
- 14 Aug 2020
Definitely in favour of merging the template views.
Just a comment here about merging the 2 views together: there are quite some issues that need to be addressed:
- Extremely hard to get thee filters working with both the templates and their styles
- The toolbar might need a bit of custom code to follow selections (template/style)
- pagination
- probably a few more that I can't even think about right now
That said combining the views is really not that hard (code wise) but we need at least for the first step some sort of design, eg and unstyled, not really functional page was just few lines:
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-01 16:58:33 |
| Closed_By | ⇒ | dgrammatiko |
So, as I promised I am going to work on finalising the child templates proposal.
The approach here is the one that was proposed by @Fedik #30149 (comment)
So far this PR is based on mild changes on the current workflow of com_templates and if this is what people are ok then the code should be ready in the coming days for testing. But since I'm spending some time reworking basically most parts of the component a better workflow, more intuitive could be a better approach here. Let me explain:
Anyways, suggestions, ideas, feedback is welcome here...