[#30345] - [4.0] Workflow in Categories should not display if Worfklow is No
- Closed
- 15 Aug 2020
- Medium
- Build: 4.0-dev
- # 30345
- Diff
- alikon:patch-81
User tests: Successful: Unsuccessful:
Pull Request for Issue #30342 .
Summary of Changes
do not render workflow tab if it is not enabled
Testing Instructions
Go to Global Configuration > Articles > Integration
Confirm Enable Workflow is No
Go to Content > Categories
Edit Uncategorised
Actual result BEFORE applying this Pull Request
the workflow tab is displayed
Expected result AFTER applying this Pull Request
the workflow tab is not displayed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
This should not be in com_categories and form fields should not be hidden in the layout like that.
I have tested this item
Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30345.
I have tested this item
Hi Nicola, thanks for this reasonable PR. One thing to consider: using the workflow in another extension will break with this check, see here for the correct call: https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/workflow/publishing/publishing.php#L462
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30345.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-15 07:22:19 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 3c49f16
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30345.