? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
11 Aug 2020

Summary of Changes

Check if multilanguage is enabled to display the language column.

Testing Instructions

Create a menu item of Single Article.
Click Select button to display modal.

Create a menu item of Menu Item Alias.
Click Select button to display modal.

Create a contact.
Create a menu item of Single Contact.
Click Select button to display modal.

Create a feed.
Create a menu item of Single News Feed.
Click Select button to display modal.

Actual result BEFORE applying this Pull Request

Language column is displayed.

Expected result AFTER applying this Pull Request

No language column.

avatar Quy Quy - open - 11 Aug 2020
avatar Quy Quy - change - 11 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2020
Category Administration com_content
avatar ceford
ceford - comment - 12 Aug 2020

Is there a way to toggle a multi-lingual site to/from single language? I guess I should be keeping a separate mono-lingual site to run tests like this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30344.

avatar infograf768 infograf768 - test_item - 12 Aug 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 12 Aug 2020

I have tested this item successfully on 1c0cf63


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30344.

avatar infograf768
infograf768 - comment - 12 Aug 2020

@Quy
I guess should be done the same for all modals like this one. Contacts, Menus (items), Newsfeeds

avatar Quy Quy - change - 12 Aug 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2020
Category Administration com_content Administration com_contact com_content com_newsfeeds
avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2020
Category Administration com_content com_contact com_newsfeeds Administration com_contact com_content com_menus com_newsfeeds
avatar Quy Quy - change - 12 Aug 2020
The description was changed
avatar Quy Quy - edited - 12 Aug 2020
avatar Quy Quy - change - 12 Aug 2020
The description was changed
avatar Quy Quy - edited - 12 Aug 2020
avatar Quy Quy - change - 12 Aug 2020
The description was changed
avatar Quy Quy - edited - 12 Aug 2020
avatar Quy Quy - change - 12 Aug 2020
The description was changed
avatar Quy Quy - edited - 12 Aug 2020
avatar brianteeman brianteeman - test_item - 16 Aug 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 16 Aug 2020

I have tested this item successfully on 881dd11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30344.

avatar richard67
richard67 - comment - 16 Aug 2020

@Quy Any reason why it is in daft status? We have 2 good tests, not sure if I shall set RTC or wait for something.

avatar richard67
richard67 - comment - 16 Aug 2020

Ah, no only 1 test. @infograf768 could you test again ?

avatar Quy
Quy - comment - 17 Aug 2020

Menus (items) is a special case. I need to investigate further to see if it needs to be done similar to default.php in the same directory. Please hold off testing. Thanks.

avatar Quy Quy - change - 17 Aug 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-08-17 21:50:36
Closed_By Quy
avatar Quy Quy - close - 17 Aug 2020
avatar Quy Quy - change - 17 Aug 2020
Status Closed New
Closed_Date 2020-08-17 21:50:36
Closed_By Quy
avatar Quy Quy - change - 17 Aug 2020
Status New Pending
avatar Quy Quy - reopen - 17 Aug 2020
avatar Quy
Quy - comment - 17 Aug 2020

False alarm. Brian's test is good. One more test needed.

avatar Quy Quy - alter_testresult - 17 Aug 2020 - brianteeman: Tested successfully
avatar infograf768 infograf768 - test_item - 18 Aug 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 18 Aug 2020

I have tested this item successfully on 9e59744


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30344.

avatar infograf768 infograf768 - change - 18 Aug 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 18 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30344.

avatar Quy Quy - change - 19 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-19 16:28:03
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 19 Aug 2020
avatar Quy Quy - merge - 19 Aug 2020
avatar brianteeman
brianteeman - comment - 19 Aug 2020

@Quy its best practice not to merge your own PR.

Add a Comment

Login with GitHub to post a comment