[#30331] - [4.0] Adding a Change button for article modal when field is required instead of the Clear button to simplify UX
- Closed
- 1 Feb 2022
- Medium
- Build: 4.0-dev
- # 30331
- Diff
- infograf768:4.0_addchangebutton
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #30289
Summary of Changes
When the article field is required, which is the case in core only when used in a single article menu item, it is useless to first Clear the field and then Select again when modifying the menu item.
In such a case, a new Change button is added and used. The button is basically using the same code as the Select button.
The reason the button is added is the fact that the code shows or hide buttons depending if the field is empty (new item then use Select) or not.
The hidden status is applied in the js depending on the situation.
When the field is NOT required, we keep the Clear button. When it is, it is now replaced by the Change button, therefore avoiding a 2 steps action.
Testing Instructions
Patch. Run npm ci.
Edit an existing single article menu item.
Create a new single article menu item.
All other cases of the modal_article field are not required and therefore will keep the Clear button (including associations)
This is totally B/C
Actual result BEFORE applying this Pull Request
When editing an existing item
Expected result AFTER applying this Pull Request
fWhen editing an existing item
For a new menu item
We keep the Clear button for Associations and elsewhere when the field is not required and the element change is not set to true
Documentation Changes Required
Yes
Note
- If this is accepted, it can be done for other components where such a
modal_xxxis used and required. - It can also be backported to 3.x
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Language & Strings JavaScript Repository NPM Change Front End |
Not sure I can modify to add this, but trying now.
@infograf768 Will there be any changes on this PR, or will it be a new one? Or in other words: Is this PR here ready?
Is this PR here ready?
Not after I discovered #30331 (comment)
Changing to Draft
jwaisner
- 
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30331.
Tested. Works as expected
@mqueme Could you also mark your test result in the issue tracker? Just go to https://issues.joomla.org/tracker/joomla-cms/30331 , use the "Test this" button, select the right test result and submit. Thanks in advance.
@infograf768 As far as I understand you want to make changes on this PR so you had set it to draft status, right?
@nadjak77 @mqueme Thanks for testing so far, but it seems it might need to be tested again later when outstanding changes have been made.
I have tested this item
Works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30331.
As it is, this can’t be merged. Did not have the opportunity to look if issue can be solved.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30331.
This can be closed.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-01 18:33:11 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
Language Change
Conflicting Files
?
Removed: ? ? |
||
I have tested this item✅ successfully on 1e62115
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30331.