[#30323] - [4.0] Fix for Synchronization of module filter when changing admin and site
- Closed
- 10 Aug 2020
- Medium
- Build: 4.0-dev
- # 30323
- Diff
- astridx:modulefilter
User tests: Successful: Unsuccessful:
Pull Request for Issue # #30302.
Summary of Changes
Add a GET-Variable for determining if client has changed.
If the filters are used, the form is submitted and the GET-variable is set. If the client changes via the menu or the Select, it is only a redirected.
Testing Instructions
See #30302.
Actual result BEFORE applying this Pull Request
See #30302.
Expected result AFTER applying this Pull Request
Filters are completely in default state (not only in view) if client changed.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-09 12:26:39 |
| Closed_By | ⇒ | astridx | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-08-09 12:26:39 | ⇒ | |
| Closed_By | astridx | ⇒ |
| Status | New | ⇒ | Pending |
The filter is collapsed upon switching, however, cpanel is still selected when filter is expanded, but not filtered.
Confirming what Quy said. Also, if I select a Site Position filter and switch back forth between Site and Administrator then the Site filter is still selected but the list is not filtered.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30323.
I thought I had a fix.
But this was bad and now I see, that joomla.resetfilter
does not work.
Not only in com_modules, in no component, or do I oversee something? In other components it is not so obviously.
So this need another fix and I close here.
Can someone reopen
Issue #30302 please.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-10 13:20:38 |
| Closed_By | ⇒ | astridx |
@astridx Why sometimes double quotes
"and sometimes single quotes'for strings? As far as I know we shall use single quotes.