? NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Razzo1987
Razzo1987
8 Aug 2020

Pull Request for Issue #30321.

Summary of Changes

Remove > .fas for the tree declaration

Testing Instructions

go to a dashboard page. See the sidebar menù

Actual result BEFORE applying this Pull Request

immagine

Expected result AFTER applying this Pull Request

immagine

Documentation Changes Required

Fix for Issue: #30321

avatar Razzo1987 Razzo1987 - open - 8 Aug 2020
avatar Razzo1987 Razzo1987 - change - 8 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Aug 2020
Category Administration Templates (admin) NPM Change
avatar richard67 richard67 - change - 8 Aug 2020
Title
[4.0] Admin Sidebar Dashboard button backgroud
[4.0] Admin Sidebar Dashboard button background
avatar richard67 richard67 - edited - 8 Aug 2020
avatar richard67
richard67 - comment - 8 Aug 2020

@Razzo1987 Thanks for your Pull Request (PR). Just in case if you consider to contribute more often, which would be very welcome of course, one information: If you have found an issue and already know how to fix it, it is enough just to make the PR. It does not need to make an issue and a PR.

avatar richard67 richard67 - test_item - 8 Aug 2020 - Tested successfully
avatar richard67
richard67 - comment - 8 Aug 2020

I have tested this item successfully on 2c5658e

Hint for other testers: It needs to run npm run build:css to compile the scss after having applied the patch of this Pull Request.

If you don't have npm, you can update to the update package built for this PR if you know how to do that, or make a new installation with the installation package built for this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30322.

avatar bonzani bonzani - test_item - 8 Aug 2020 - Tested successfully
avatar bonzani
bonzani - comment - 8 Aug 2020

I have tested this item successfully on 2c5658e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30322.

avatar richard67 richard67 - change - 8 Aug 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 8 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30322.

avatar richard67 richard67 - change - 8 Aug 2020
Labels Added: ? ? ? NPM Resource Changed
avatar infograf768 infograf768 - change - 8 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-08 19:03:30
Closed_By infograf768
Labels
avatar infograf768 infograf768 - close - 8 Aug 2020
avatar infograf768 infograf768 - merge - 8 Aug 2020
avatar infograf768
infograf768 - comment - 8 Aug 2020

tks

Add a Comment

Login with GitHub to post a comment