[#30294] - [4.0] Atum and Cassiopea Change alerts styling - space saving +
- Fixed in Code Base
- 11 Aug 2020
- Medium
- Build: 4.0-dev
- # 30294
- Diff
- infograf768:4_0_atum_alerts
User tests: Successful: Unsuccessful:
Replaces #28974
Thanks @coolcat-creations for the original PR, here improved
Thanks @Fedik for the suggestions
Summary of Changes
Changed the Header of the message to be next to the message to save space
Decreased paddings
Changed colors
Normalise system.message layout and message.es6 by using div instead of span and p tags
Testing Instructions
Edit or create an article. Let title empty and save.
Install a clean Joomla after patching to test installation errors, see #30294 (comment)
Patch. Run npm.
Test various messages including in the login page.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change JavaScript Repository Layout |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration Templates (admin) NPM Change JavaScript Repository Layout | ⇒ | Administration Templates (admin) NPM Change JavaScript Repository Layout Front End Plugins |
I personally like the current styling even though it takes up a little more spacing.
My bad, I didn't compile JS. Still looks bad on frontend and on mobile.
My bad, I didn't compile JS. Still looks bad on frontend and on mobile.
Backend:
On mobile I see no specific issue.
Frontend
I had never tested in frontend. ;)
It needs some supplementary work indeed. Looking at it now.
| Category | Administration Templates (admin) NPM Change JavaScript Repository Layout Front End Plugins | ⇒ | Administration Templates (admin) NPM Change JavaScript Repository Layout Front End Plugins Templates (site) |
| Title |
|
||||||
Adapt alerts in Cassiopea too:
@infograf768 Drone shows some scss code style errors in its test "scss-cs", see here: https://ci.joomla.org/joomla/joomla-cms/34516/1/24. Could you fix that?
On it
@richard67
Completed
Will complete Pr tomorrow with alerts in Installation
@helvecio - maybe relevant in the Frontend Template design
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30294.
| Category | Administration Templates (admin) NPM Change JavaScript Repository Layout Front End Plugins Templates (site) | ⇒ | Administration Templates (admin) NPM Change JavaScript Repository Installation Layout Front End Plugins Templates (site) |
Modifications done for Installation.
We now get:
Folks, please now test.
I know... have again to correct order in scss. Will do later.
This can also be tested when installing a clean J to test install errors.
For example: enter a wrong db credential or trying to install a language which is not available for j4 (Afrikaans will do).
Prebuilt package can help people not using npm ci
https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30294/downloads/34546/
Either I did something wrong (which I always consider as possible), or the installation is missing some (s)css:
I did an npm run build:css after having applied the PR, and I cleared browser cache, too, and I've verified that the changes in file installation/template/scss/template.scss have been correctly applied by patchtester.
False alarm. It seems that stuff is really sticky in browser cache. After not having only cleared the cache but also having closed the browser window after that, and having run npm ci instead of compiling the scss only, all looks well:
@infograf768 Sorry for false alarm.
I have tested this item
Tested alerts on installation, the statistics alert after installation, alerts in backend and frontend.
The latter (alerts in backend and frontend) I've also tested with RTL language (Persian).
All fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30294.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30294.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30294.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-11 10:33:25 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Personally I kinda like the new look. Thanks @coolcat-creations and @infograf768 !