Feeling Lucky
?
[#30275] - Update validate.js
- Closed
- 7 Aug 2020
- Medium
- Build: staging
- # 30275
- Diff
- Lab5-Switzerland:patch-1
User tests: Successful: 0 Unsuccessful: 0
I simply put
new RegExp(" ... ")
around the email validation RegEx.
Reason : At least one very famous JS minifier which is in widespread use does stumble over this complex pattern, especially because they have problem recognizing them as such in the first place.
The simple 'wrap' makes it clearly and surely possible to identify the RegEx as such.
The Minifier I tested the most with and draw my conclusion from is JShrink from tedious ( https://github.com/tedious/JShrink ).
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-07 15:07:13 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Please make further changes in #30276.