? ?
avatar brianteeman
brianteeman
29 Jul 2020

#29251 has broken this because it change the link in the top right to com_admin from com_users without actually putting the accessibility code in com_admin

avatar brianteeman brianteeman - open - 29 Jul 2020
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Jul 2020
avatar brianteeman
brianteeman - comment - 22 Aug 2020

Can this be upgraded to a release blocker as it is a major loss of advertised features

avatar ceford
ceford - comment - 22 Aug 2020

To figure what to do I copied and pasted the User Accessibility form settings from user.xml to profile.xml before the closing param and I coped the A11Y ini values from com_admin.ini to com_users.ini. That works - but what about the Accessibility Settings in the user menu? Both links lead to the last open tab. So should one be removed? It all needs the ini keys changing of course. Is this the right way forward?

avatar brianteeman
brianteeman - comment - 22 Aug 2020

. Is this the right way forward?

No

avatar ceford
ceford - comment - 22 Aug 2020

. Is this the right way forward?

No

Any hints on the right way? I have a J3 site with a group of users who do not have access to com_users. They might like to set personal accessibility features via the profile form. However, they should not really have access to Basic Settings, User Actions Log Options or Joomla API Token. So I will need to create a template override. Should Accessibility go into a different view? Or layout?

avatar brianteeman
brianteeman - comment - 22 Aug 2020

the changes that broke this should be reverted. then it works as you want

avatar Quy Quy - change - 22 Aug 2020
Labels Added: ? ?
avatar Quy Quy - labeled - 22 Aug 2020
avatar Quy Quy - labeled - 22 Aug 2020
avatar ceford
ceford - comment - 23 Aug 2020

I had a look at the commit that implemented the changes for #29251 and noted that both links in mod_user/tmpl/default.php (Edit Account and Accessibility Settings) changed from com_users to com_admin. I think that is right because I was among those who previously reported that it was not possible for a user without permission to access com_users to change password. So it seems to me that fixing the second link by removal is the simplest solution for now (changing back to com_users&task=user.edit needs a check that the user is allowed access to com_users).

avatar brianteeman
brianteeman - comment - 23 Aug 2020

simplest but not correct

avatar chmst
chmst - comment - 29 Dec 2020

I don't like the term (and link) for accessibility settings at all.
Why not integrate the fields monochrome, fonts and highlight links into user settings?
High contrast has no effect.

avatar brianteeman
brianteeman - comment - 29 Dec 2020

That is how it was

avatar Hackwar
Hackwar - comment - 7 Jan 2021

Here is a PR: #31884
I don't see why we shouldn't fix this issue this way. Switching it back to com_users is not a viable solution.

avatar brianteeman
brianteeman - comment - 7 Jan 2021

That's a bandaid not a fix. Not only do you end up with a lot of duplicated code but even with your proposal there are still fields missing from the com_admin version of the user data. Developers always tell me that duplicated code is bad.

avatar Hackwar
Hackwar - comment - 8 Jan 2021

Yes, duplicate code is bad, however the alternative is rewriting com_users and that is not something that I want to do (now). I also don't see which fields are missing, which a normal user needs access to.

avatar chmst
chmst - comment - 8 Jan 2021

Why not integrate the fields monochrome, fonts and highlight links into user settings?

Seems that this was a misunderstanding. With user settings I am speaking about the tabs on the screen, not about the component com_users. It is ok as it is now in com_admin.

avatar joomdonation
joomdonation - comment - 21 Mar 2021

@brianteeman Could you please take a quick look at this PR #32771 to see if it address your concern?

avatar richard67 richard67 - change - 21 Mar 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-03-21 14:15:06
Closed_By richard67
Labels Added: ?
Removed: ?
avatar richard67 richard67 - close - 21 Mar 2021
avatar richard67
richard67 - comment - 21 Mar 2021

Closing as having a pull request. Please test #32771 . Thanks in advance.

avatar rdeutz rdeutz - change - 23 Mar 2021
Labels Removed: ?
avatar rdeutz rdeutz - unlabeled - 23 Mar 2021

Add a Comment

Login with GitHub to post a comment