[#30216] - [4.0] Fix wrong aria usage accordion view
- Closed
- 4 Sep 2020
- Medium
- Build: 4.0-dev
- # 30216
- Diff
- Quy:29924-accordion
User tests: Successful: Unsuccessful:
Pull Request for Issue #29924.
Summary of Changes
The accordion view is still using tab-aria syntax.
Code provided by @angieradtke.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
Sorry code review really is not enough. Where is this code being used so that it can be tested correctly
@brianteeman select menu types is an accordion
There is no question that after this PR the behaviour of selecting menu types is improved (and probably can be improved further with lists instead of a bunch of links) my question is whether this is the right file to change.
The code being changed is
Add javascript support for Bootstrap accordions and insert the accordion
surely therefore this file should not be changed and we should have our own code for the accordion??
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-04 14:23:11 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on dda3952
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30216.