[#30170] - [4.0] Fix admin menu collapse when joomla is in a folder with uppercase name
- Fixed in Code Base
- 23 Jul 2020
- Medium
- Build: 4.0-dev
- # 30170
- Diff
- infograf768:4.0_admin_menu_uppercase_folder
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #30155
Summary of Changes
mod_menu js is comparing a lowercase url to one that may not be
Testing Instructions
Install Joomla in a subfolder and use UpperCase letters for that subfolder name.
For example:
domain.org/newFolder/
Click the "Content" item in the admin menu, it reveals its sub-items.
Click the "Articles" item.
Patch. Run npm ci and test again.
Actual result BEFORE applying this Pull Request
see #30155
The admin menu returns to its default closed state
Expected result AFTER applying this Pull Request
The admin menu remains open with the submenu highlighted, as should.
Here Joomla is in a sub-sub-folder, one of them with a Uppercase letter in its name.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
It’s fine
I am trying to test the patch, but get following message:
"There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation."
?
Jan
Here is the link to a prebuilt package to install into your folder
https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30170/downloads/34141/Joomla_4.0.0-beta3-dev+pr.30170-Development-Full_Package.zip
Here is the link to a prebuilt package to install into your folder
https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30170/downloads/34141/Joomla_4.0.0-beta3-dev+pr.30170-Development-Full_Package.zip
@PhocaCz Additional info: The package contains already the changes from this PR, including the results of the npm run. So just make a new installation with that package and you can test.
@PhocaCz This PR requires the build folder to be present and to run npm. This works only when testing on a git clone. If you have a regular installation of J4 where the build folder is not present, patchtester can't apply this PR.
I use standard composer|npm. The folder "build" is included, running npm after clicking on "apply patch" in fact didn't do any change as the patch was not applied.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30170.
I have tested this item
Tested successfully:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30170.
Here is the link to a prebuilt package to install into your folder
https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30170/downloads/34141/Joomla_4.0.0-beta3-dev+pr.30170-Development-Full_Package.zip
I can confirm that this fix is working, the menus behave as expected on an UpperCase subfolder.
Thank you!
BTW, @richard67 thank you for your help.
The problem, why I was not able to patch it, was inside "installation" folder. No idea why, but "language" folder was missing there.
After copying it back, everything went OK.
@PhocaCz What do you mean with "automatically confirm"?
I thought it was necessary to have an active patch in the administration to confirm. Now I see, it is not needed.
Thank you, Jan
@JackJoeJack Could you mark your test result as successful on the issue tracker here https://issues.joomla.org/tracker/joomla-cms/30170? Just use the "Test this" button, select the right test result and submitt. Thanks in advance.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30170.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30170.
Quy
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-23 13:47:13 |
| Closed_By | ⇒ | Quy | |
| Labels | |||
@dgrammatiko
I guess you were the one who first created this js. Any comment?