Feeling Lucky
?
NPM Resource Changed
?
?
[#30162] - [4.0] Split up installer plugin JS
- Fixed in Code Base
- 4 Aug 2020
- Medium
- Build: 4.0-dev
- # 30162
- Diff
- SharkyKZ:j4/js/installer
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #30017
Summary of Changes
Moves installer plugin JS to separate files for each plugin.
Fixes markup generating empty tabset.
Moves plugin-specific language strings to plugins.
Testing Instructions
node build.js --compile-js required.
- Test that all extension install methods still work.
- Disable all installer plugins. Go to extension installer.
Actual result BEFORE applying this Pull Request
- JS errors:
Uncaught TypeError: document.getElementById(...) is null --- media/com_installer/js/installer.min.js
Uncaught TypeError: i[0] is undefined --- media/vendor/joomla-custom-elements/js/joomla-tab.min.js
Expected result AFTER applying this Pull Request
- Works like before.
- No JS errors.
Documentation Changes Required
IDK.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer Language & Strings JavaScript Repository NPM Change Front End Plugins |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
jmeintrup
- comment
- 4 Aug 2020
I have tested this item
Prepatch: Browser Console outputs errors as described
Postpatch: No Errors in Console
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30162.
roland-d
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-04 08:57:02 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 080e1ef
After applying this PR and running the command, the installer plugins still work and there are no more JS errors
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30162.