? ? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
21 Jul 2020

Pull Request for Issue #30074 .

Summary of Changes

Log the Joomla update event on the Actionlogs

Testing Instructions

joomlaupdate -> options
change to Custom URL
and put this manifest https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/30157/downloads/34205/pr_list.xml
you'll find it here on the download pkg link Prebuilt packages are available for download.

Actual result BEFORE applying this Pull Request

no event is logged when joomla update

Expected result AFTER applying this Pull Request

the event is logged
Screenshot from 2020-07-21 19-39-11

Documentation Changes Required

avatar alikon alikon - open - 21 Jul 2020
avatar alikon alikon - change - 21 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2020
Category Administration com_joomlaupdate Language & Strings Front End Plugins
avatar alikon alikon - change - 21 Jul 2020
The description was changed
avatar alikon alikon - edited - 21 Jul 2020
avatar alikon alikon - change - 21 Jul 2020
Labels Added: ? ?
avatar ChristineWk ChristineWk - test_item - 21 Jul 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 21 Jul 2020

I have tested this item successfully on 7b32ca9

Got: User xyz updated the CMS to 3.9.21-dev+pr.30157


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30157.

avatar SharkyKZ
SharkyKZ - comment - 21 Jul 2020

There are already onJoomlaBeforeUpdate and onJoomlaAfterUpdate events in 4.0.

avatar alikon
alikon - comment - 21 Jul 2020

but they are used just for plugin installer/override
so what we can do ?

avatar LukeDouglas2
LukeDouglas2 - comment - 21 Jul 2020

Thanks mates!

avatar SharkyKZ
SharkyKZ - comment - 22 Jul 2020

but they are used just for plugin installer/override
so what we can do ?

They can be used by any plugin.

avatar ChristineWk
ChristineWk - comment - 24 Jul 2020

Made as in the first test on another Site. (J!3.9.21-dev+pr.30157 was available).
But got: Download failed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30157.
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2020
Category Administration com_joomlaupdate Language & Strings Front End Plugins Administration Language & Strings Front End Plugins
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2020
Category Administration Language & Strings Front End Plugins Administration com_joomlaupdate Language & Strings Front End Plugins
avatar alikon alikon - change - 26 Jul 2020
The description was changed
avatar alikon alikon - edited - 26 Jul 2020
avatar alikon alikon - change - 26 Jul 2020
The description was changed
avatar alikon alikon - edited - 26 Jul 2020
avatar alikon
alikon - comment - 26 Jul 2020

as suggested #30157 (comment) in j4 there is already such event onJoomlaAfterUpdate

made the relative changes

please re-test

avatar ChristineWk ChristineWk - test_item - 26 Jul 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 26 Jul 2020

I have tested this item successfully on 19414dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30157.

avatar viocassel viocassel - test_item - 26 Jul 2020 - Tested successfully
avatar viocassel
viocassel - comment - 26 Jul 2020

I have tested this item successfully on 19414dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30157.

avatar Quy Quy - change - 26 Jul 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30157.

avatar HLeithner HLeithner - change - 17 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-17 10:45:22
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 17 Aug 2020
avatar HLeithner HLeithner - merge - 17 Aug 2020
avatar HLeithner
HLeithner - comment - 17 Aug 2020

Thanks

Add a Comment

Login with GitHub to post a comment