[#30142] - [staging] [fields plugins] Deleting use of Telephone filter as it is broken
- Closed
- 12 Jun 2022
- Medium
- Build: staging
- # 30142
- Diff
- infograf768:fields_telephone
- Success Hound Smells good to me. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18566
Summary of Changes
The TEL Form filter being totally broken ( https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Form/Form.php#L1466-L1544 ), the filter should never be used in the fields parameters.
Changing telephone filter tel to text in sql upgrade #__fields table for B/C.
Taking off the Telephone filter in the fields plugin parameters.
Testing Instructions
Create 3 fields (type text, textarea, repeatable->text
Use the Telephone filter => number always get an unwanted period when saved when editing an article, various formats are not honored.
Patch and try to create new fields of the same type (no need to save them)
The filter field telephone is no more proposed.
Use the new sql update => all existing fields which have been set with the tel filter are modified to use the text filter.
@richard67
I only created the sql update for mysql. Please add for postgresql and sqlazure
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Front End Plugins |
| Labels |
Added:
?
|
||
| Category | SQL Administration com_admin Front End Plugins | ⇒ | SQL Administration com_admin Postgresql MS SQL Front End Plugins |
Done. Tks.
It seems the language string can either be removed or be marked as deprecated, not sure what's the right way.
As far as I could see it is only used at places where it is removed with this PR:
richard@vmkubu02:~/lamp/public_html/joomla-cms-4.0-dev$ find ./ -type f -name "*\.*" -exec grep -iHn "JLIB_FILTER_PARAMS_TEL" {} \;
./administrator/language/en-GB/lib_joomla.ini:317:JLIB_FILTER_PARAMS_TEL="Telephone"
./plugins/fields/text/text.xml:39: <option value="tel">JLIB_FILTER_PARAMS_TEL</option>
./plugins/fields/text/params/text.xml:20: <option value="tel">JLIB_FILTER_PARAMS_TEL</option>
./plugins/fields/textarea/textarea.xml:62: <option value="tel">JLIB_FILTER_PARAMS_TEL</option>
./plugins/fields/textarea/params/textarea.xml:41: <option value="tel">JLIB_FILTER_PARAMS_TEL</option>
./language/en-GB/lib_joomla.ini:317:JLIB_FILTER_PARAMS_TEL="Telephone"
richard@vmkubu02:~/lamp/public_html/joomla-cms-4.0-dev$
One never knows what one does with some core strings. Also, let's hope someone, one day, when on booze, corrects the TEL filter...
I see, one could still use the filter from the library and the corresponding text in some 3rd party stuff. All fine.
@HLeithner
I guess this PR interests no one. Can you still get it in?
Why don't we fix it?
Good luck for that. The preg are very complex.
I have no idea who has done that code and it was never used in core until these fields were created.
Use the new sql update
How?
Usually running the update query with PhpMyadmin, replacing #__fields by your db prefix.
But it looks like this PR is not going to make it...
Formatio-hippocampi
-
I have tested this item
Filter "Telephone" deleted, but after SQL-Update:
- "Text" and "Textarea" > "Use Settings from Plugin" (which is "Text")
- "Repeatable" > "No"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30142.
Use the new sql update => all existing fields which have been set with the
telfilter are modified to use thetextfilter.
- Field
TextandTextareahas FilterUse Settings from Plugin(notTextas written in Testing Instructions) - Field
Repeatablehas FilterNo(notTextas written in Testing Instructions)
You are right and it looks like not fully.
What I found out.
Indeed when editing the field itself, it displays what you wrote.
But if you do not modify the field, when using the field when editing an article it uses the text filter.
It's weird indeed. I can't find the reason.
@infograf768 I would say we should close this PR for J3 and not break other sites. For now we could start a new PR to fix the migration sql against j4.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-12 17:51:33 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
Removed: ? |
||
@infograf768 I would say we should close this PR for J3 and not break other sites. For now we could start a new PR to fix the migration sql against j4.
@zero-24 Who will do the new PR? I don't think @infograf768 is still available.
And should the issue https://github.com/joomla/joomla-cms/issues/18566 be re-opened?
It should imho
Done, see infograf768#56 .