NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
19 Jul 2020

Pull Request for Issue #30138 .

Summary of Changes

This is somehow tricky as the content of this panel is delivered from the JED.

I added a own class to the whole panel. This enables styling of the cards in a way that they fit better.
This means we now have a new file com_installer.scss.

  • I removed the top border radius from the images
  • Force the images to height 5rem. This meand that huge images are compressed - this is not beautiful, but huge images are not good either
  • Reduced the padding around texts
  • Made more top margin between cards
  • Hide overrides

Please note: This does NOT resolve problems of this view on small devices, as the output is generated (as row instead of row-fluid) somewhere .. .

Testing Instructions

Look a at the webinstaller tab. You see some cards with big images where the text is outside the cards.
Apply the patch and run npm
Look again, all images have same height and nothing overlaps the card borders.

Actual result BEFORE applying this Pull Request

See the issue #30138

Expected result AFTER applying this Pull Request

install-from-web

Documentation Changes Required

no

avatar chmst chmst - open - 19 Jul 2020
avatar chmst chmst - change - 19 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jul 2020
Category Administration Templates (admin) NPM Change Front End Plugins
avatar chmst chmst - change - 19 Jul 2020
Labels Added: ?
avatar chmst chmst - change - 19 Jul 2020
Category Administration Templates (admin) NPM Change Front End Plugins Administration NPM Change Plugins Templates (admin)
avatar chmst chmst - change - 19 Jul 2020
The description was changed
avatar chmst chmst - edited - 19 Jul 2020
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jul 2020
Category Administration Templates (admin) NPM Change Plugins Administration Templates (admin) NPM Change Front End Plugins
avatar SharkyKZ
SharkyKZ - comment - 19 Jul 2020

Move SCSS to build/media_source/plg_installer_webinstaller/scss.

avatar chmst chmst - change - 19 Jul 2020
The description was changed
avatar chmst chmst - edited - 19 Jul 2020
avatar uglyeoin
uglyeoin - comment - 19 Jul 2020

I still see this issue: https://nimb.ws/3CvqtB have I definitely installed the patch correctly? I used patchtester. What is the correct way to run NPM? I tried NPM install in the root but there is no package.json file.

avatar chmst
chmst - comment - 20 Jul 2020

@uglyeoin ~i am not sure if the patchtester adds new files. Please check if in administrator/templates/scss/pages you have the file com_installer.scss ~
my fault. renamed com_installer.scss to _com_installer.css.

avatar chmst chmst - change - 20 Jul 2020
Labels Added: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2020
Category Administration Templates (admin) NPM Change Plugins Front End Repository NPM Change
avatar chmst
chmst - comment - 20 Jul 2020

Follwing @SharkyKZ I moved the css to the plugin. This indeed is much better. So no need to add something to the template atum, just changes in the plugin's scss are nedded

avatar mbabker
mbabker - comment - 20 Jul 2020

Please note: This does NOT resolve problems of this view on small devices, as the output is generated (as row instead of row-fluid) somewhere .. .

@chmst :

  1. Bootstrap 4 does not have a row-fluid class so unless Joomla is hacking in its own Bootstrap customizations again then this would probably break more than it fixes
  2. That "somewhere" is https://github.com/joomla/install-from-web-server, it has been on GitHub in a publicly accessible repository with a clearly identifying name since 2013

<rant>What is so hard about finding the source code for things coming from joomla.org to be able to make changes? Seriously, if it's not included into this repo, it's almost like people think you have to know the super secret squirrel handshake to see something, whereas I bent over backwards to make sure damn near every repository that could be public was made public to prevent people doing the "I don't know where this is or who the one person in the entire project that is responsible for this" problem from being a thing.</rant>

What is the correct way to run NPM? I tried NPM install in the root but there is no package.json file.

@uglyeoin If you do not have Joomla cloned from the git repository then you cannot use com_patchtester on any pull request which requires the use of the composer or npm command line binaries.

avatar mbabker
mbabker - comment - 20 Jul 2020

Sorry, I forgot it's considered toxic for being irritated that people constantly point out issues with the help screen proxy or install from web but also say that those things are coming from "somewhere" as if I have those systems as private, invite-only repositories, on my personal account. It's actually quite frustrating for me to constantly have to remind people that I don't want to be the single administrator for these systems, and that these systems are open source and readily available for anyone to find or contribute to.

avatar chmst chmst - change - 20 Jul 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-07-20 14:30:28
Closed_By chmst
avatar chmst chmst - close - 20 Jul 2020
avatar infograf768
infograf768 - comment - 20 Jul 2020

To all : please wear a mask. Toxicity and irritation are Covid-related.

avatar chmst chmst - change - 21 Jul 2020
Status Closed New
Closed_Date 2020-07-20 14:30:28
Closed_By chmst
avatar chmst chmst - change - 21 Jul 2020
Status New Pending
avatar chmst chmst - reopen - 21 Jul 2020
avatar Quy Quy - test_item - 21 Jul 2020 - Tested successfully
avatar Quy
Quy - comment - 21 Jul 2020

I have tested this item successfully on 1b62faa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30140.

avatar jwaisner jwaisner - test_item - 24 Jul 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 24 Jul 2020

I have tested this item successfully on 1b62faa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30140.

avatar jwaisner jwaisner - change - 24 Jul 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 24 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30140.

avatar Quy Quy - change - 24 Jul 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-24 03:16:06
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 24 Jul 2020
avatar Quy Quy - merge - 24 Jul 2020

Add a Comment

Login with GitHub to post a comment