User tests: Successful: Unsuccessful:
Pull Request for Issue #30138 .
This is somehow tricky as the content of this panel is delivered from the JED.
I added a own class to the whole panel. This enables styling of the cards in a way that they fit better.
This means we now have a new file com_installer.scss.
Please note: This does NOT resolve problems of this view on small devices, as the output is generated (as row instead of row-fluid) somewhere .. .
Look a at the webinstaller tab. You see some cards with big images where the text is outside the cards.
Apply the patch and run npm
Look again, all images have same height and nothing overlaps the card borders.
See the issue #30138
no
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change Front End Plugins |
Labels |
Added:
?
|
Category | Administration Templates (admin) NPM Change Front End Plugins | ⇒ | Administration NPM Change Plugins Templates (admin) |
Category | Administration Templates (admin) NPM Change Plugins | ⇒ | Administration Templates (admin) NPM Change Front End Plugins |
I still see this issue: https://nimb.ws/3CvqtB have I definitely installed the patch correctly? I used patchtester. What is the correct way to run NPM? I tried NPM install in the root but there is no package.json file.
Labels |
Added:
NPM Resource Changed
|
Category | Administration Templates (admin) NPM Change Plugins Front End | ⇒ | Repository NPM Change |
Please note: This does NOT resolve problems of this view on small devices, as the output is generated (as row instead of row-fluid) somewhere .. .
@chmst :
row-fluid
class so unless Joomla is hacking in its own Bootstrap customizations again then this would probably break more than it fixes<rant>
What is so hard about finding the source code for things coming from joomla.org
to be able to make changes? Seriously, if it's not included into this repo, it's almost like people think you have to know the super secret squirrel handshake to see something, whereas I bent over backwards to make sure damn near every repository that could be public was made public to prevent people doing the "I don't know where this is or who the one person in the entire project that is responsible for this" problem from being a thing.</rant>
What is the correct way to run NPM? I tried NPM install in the root but there is no package.json file.
@uglyeoin If you do not have Joomla cloned from the git repository then you cannot use com_patchtester on any pull request which requires the use of the composer
or npm
command line binaries.
Sorry, I forgot it's considered toxic for being irritated that people constantly point out issues with the help screen proxy or install from web but also say that those things are coming from "somewhere" as if I have those systems as private, invite-only repositories, on my personal account. It's actually quite frustrating for me to constantly have to remind people that I don't want to be the single administrator for these systems, and that these systems are open source and readily available for anyone to find or contribute to.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-20 14:30:28 |
Closed_By | ⇒ | chmst |
To all : please wear a mask. Toxicity and irritation are Covid-related.
Status | Closed | ⇒ | New |
Closed_Date | 2020-07-20 14:30:28 | ⇒ | |
Closed_By | chmst | ⇒ |
Status | New | ⇒ | Pending |
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-24 03:16:06 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
|
Move SCSS to
build/media_source/plg_installer_webinstaller/scss
.