[#30111] - [com_messages] Validate message and user ID
- Fixed in Code Base
- 17 Aug 2020
- Medium
- Build: staging
- # 30111
- Diff
- Quy:29562-j3-reply-id
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #29562.
Summary of Changes
Check message exists and compare user_id to ensure there is a message sent to the user to reply to.
Add space before subject in reply.
Testing Instructions
Fake a reply_id:
/administrator/index.php?option=com_messages&view=message&layout=edit&reply_id=666999666
Actual result BEFORE applying this Pull Request
Enable Maximum in Error Reporting.
Check PHP error log.
PHP Notice: Trying to get property 'user_id_from' of non-object in \administrator\components\com_messages\models\message.php on line 158
PHP Notice: Trying to get property 'subject' of non-object in \administrator\components\com_messages\models\message.php on line 161
PHP Notice: Trying to get property 'subject' of non-object in \administrator\components\com_messages\models\message.php on line 163
Expected result AFTER applying this Pull Request
An error message
500 You are not authorised to view this resource.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_messages |
Same notice in J4.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30111.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30111.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30111.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-17 10:41:05 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
Thanks
I have tested this item✅ successfully on 51403e4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30111.