[#30110] - Remove unneeded strings from robots parameter
- Fixed in Code Base
- 17 Aug 2020
- Medium
- Build: staging
- # 30110
- Diff
- Bakual:3_RemoveUnneededStrings
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Based on some discussions (see #29595 (comment)) initiated by a translator I'm proposing to completely remove the usage of the following strings and deprecated them.
JGLOBAL_INDEX_FOLLOW="Index, follow"
JGLOBAL_INDEX_NOFOLLOW="Index, no follow"
JGLOBAL_NOINDEX_FOLLOW="No index, follow"
JGLOBAL_NOINDEX_NOFOLLOW="No index, no follow"
In J4 they can be removed completely.
Reason is that they are now marked as "not to translate". But if a complete string shouldn't be translated, it doesn't make sense to have them as language strings to begin with.
Summary of Changes
Removing the strings from the XML. Instead the list will now directly show the value.
Deprecating the strings so they can still be used by 3rd parties but will get removed with J4.
The global configuration is a bit different since for some reason the first option is currently an empty value (<option value="">JGLOBAL_INDEX_FOLLOW</option>). I've changed that to <option value="">index, follow</option> so the behavior is the same.
Testing Instructions
Check the robots parameters in the global configuration and the various other places (eg category, article, contact, ...)
No difference before and after the PR.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_config com_contact com_content com_menus com_newsfeeds com_tags Language & Strings Front End |
I thought they were already marked as deprecated - my bad for not checking properly - because that is what was decided
It seems this PR includes some unrealted changes?
PhpStorm automatically removed some superfluous spaces in the article.xml and item_component.xml. It's only CS stuff which should be simple to review.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30110.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30110.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30110.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-17 10:40:05 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
Thanks
It seems this PR includes some unrealted changes?