Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30054] - [4.0] Flush the opcache on extension install to ensure consistency

? Failure

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
8 Jul 2020

Closes #30050

Summary of Changes

addition of opcache_reset() after an attempted installation of a package/extension regardless of the result

Testing Instructions

apply PR, test you can still install extensions, noting that the opcache will be reset on installing

Actual result BEFORE applying this Pull Request

opcache not reset when installing extensions leading to inconsistency in some configurations

Expected result AFTER applying this Pull Request

opcache resets on attempting to install extensions

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 8 Jul 2020
avatar PhilETaylor PhilETaylor - change - 8 Jul 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jul 2020
Category ⇒ Libraries
avatar SharkyKZ
SharkyKZ - comment - 8 Jul 2020

Add function_exists() check.

avatar PhilETaylor PhilETaylor - change - 8 Jul 2020
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 8 Jul 2020

Add function_exists() check.

Done.

avatar PhilETaylor PhilETaylor - change - 8 Jul 2020
Title
…
Flush the opcache regardless on extension install to ensure consistency
[4.0] Flush the opcache regardless on extension install to ensure consistency
avatar PhilETaylor PhilETaylor - edited - 8 Jul 2020
avatar PhilETaylor PhilETaylor - change - 8 Jul 2020
Title
…
[4.0] Flush the opcache regardless on extension install to ensure consistency
Flush the opcache on extension install to ensure consistency
avatar PhilETaylor PhilETaylor - edited - 8 Jul 2020
avatar PhilETaylor PhilETaylor - change - 8 Jul 2020
Title
…
Flush the opcache on extension install to ensure consistency
[4.0] Flush the opcache on extension install to ensure consistency
avatar PhilETaylor PhilETaylor - edited - 8 Jul 2020
avatar ceford ceford - test_item - 7 Aug 2020 - Tested successfully
avatar ceford
ceford - comment - 7 Aug 2020

I have tested this item ✅ successfully on 9ccd032

After applying the patch I can install components - don't know how to test whether opcache has actually been reset.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30054.

avatar particthistle
particthistle - comment - 1 Nov 2020

I'd test, but as @ceford indicated, I don't know how to test whether opcache has actually been reset and looking at #30050 I also don't know if an extension I'm installing is affected by the problem.

@joeforjoomla as #30050 was something you initially spotted, can you test or can someone supply an extension to test in the process?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30054.

avatar joeforjoomla joeforjoomla - test_item - 1 Nov 2020 - Tested successfully
avatar joeforjoomla
joeforjoomla - comment - 1 Nov 2020

I have tested this item ✅ successfully on 9ccd032

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30054.

avatar richard67 richard67 - alter_testresult - 1 Nov 2020 - ceford: Tested successfully
avatar richard67 richard67 - alter_testresult - 1 Nov 2020 - joeforjoomla: Tested successfully
avatar richard67
richard67 - comment - 1 Nov 2020

I've restored previous test results because only change after tests was a clean branch update.

avatar richard67 richard67 - close - 1 Nov 2020
avatar richard67 richard67 - merge - 1 Nov 2020
avatar richard67 richard67 - change - 1 Nov 2020
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-11-01 12:39:29
Closed_By ⇒ richard67
avatar richard67
richard67 - comment - 1 Nov 2020

Thanks!

Add a Comment

Login with GitHub to post a comment