? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
8 Jul 2020

Pull Request for Issue # .
patchtester #277

Summary of Changes

add refresh to mapping

Testing Instructions

verify fetch in patchtester now maps correctly.

Actual result BEFORE applying this Pull Request

fetch icon empty

Expected result AFTER applying this Pull Request

fetch icon displays.

Documentation Changes Required

none

avatar N6REJ N6REJ - open - 8 Jul 2020
avatar N6REJ N6REJ - change - 8 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jul 2020
Category Libraries
avatar N6REJ N6REJ - change - 8 Jul 2020
The description was changed
avatar N6REJ N6REJ - edited - 8 Jul 2020
avatar ceford
ceford - comment - 9 Jul 2020

I applied the patch with Patch Tester but the refresh icon is still missing. Inspector tells me there is no content. I guess this means the css needs to be recompiled to test properly (by others).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30053.

avatar brianteeman
brianteeman - comment - 9 Jul 2020

@ceford there are no css changes in this pr so if the pr is correct then you should see the changes

avatar ceford
ceford - comment - 9 Jul 2020

I don't see fa-refresh in the font awesome docs - should it be fa-sync?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30053.

avatar ceford
ceford - comment - 9 Jul 2020

I should have said - using fa-sync works without the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30053.

avatar N6REJ
N6REJ - comment - 9 Jul 2020

@ceford hi cliff.. your 100% right, fa-sync is correct and does work if you do it manually.. I'm firing things up as we speak to see whats what.
I THINK the problem is pt keeps putting icon- in and it shouldn't be doing that but I've not figured out where/why yet.

avatar N6REJ N6REJ - change - 11 Jul 2020
Labels Added: ?
avatar N6REJ N6REJ - change - 11 Jul 2020
Title
[4.0][DRAFT] add refresh to mapping
[4.0] add refresh to grid mapping
avatar N6REJ N6REJ - edited - 11 Jul 2020
avatar richard67
richard67 - comment - 12 Jul 2020

@N6REJ For the PT this PR doesn't help much, because this PR deals with JGrid, i.e. the list views, while for PT it would need to work on the Toolbar Helper.

avatar N6REJ N6REJ - close - 13 Jul 2020
avatar N6REJ
N6REJ - comment - 13 Jul 2020

closing as irrelevant.

avatar N6REJ N6REJ - change - 13 Jul 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-07-13 18:13:51
Closed_By N6REJ

Add a Comment

Login with GitHub to post a comment