[#29987] - Feature/draggable typo fixes
- Fixed in Code Base
- 20 Jul 2020
- Medium
- Build: 4.0-dev
- # 29987
- Diff
- hans2103:feature/draggable-typo-fixes
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
continue from #29984 (comment)
Searched for dragable and replaced by draggable
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_menus com_modules com_newsfeeds com_plugins com_tags com_workflow JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@ceford That is due to the fact that all files in /media are in .gitignore
I cannot create a pull request for that one.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987.
The media folder should not have that any more after running npm. An other way to test that would be the pre build packages there npm should have rebuild them already.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987.
I have added the merge in commit hans2103@89c852e
I added the changes of the two files in commit hans2103@e7490ea
They are in branch https://github.com/hans2103/joomla-cms/commits/feature/draggable-typo-fixes
But I don't see them in this GitHub issue.
Any idea why?
| Labels |
Added:
?
|
||
| Category | Administration com_banners com_categories com_contact com_content com_menus com_modules com_newsfeeds com_plugins com_tags com_workflow JavaScript Repository NPM Change | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_menus com_modules com_newsfeeds com_plugins com_tags com_workflow JavaScript Repository NPM Change |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-20 19:06:11 |
| Closed_By | ⇒ | richard67 |
Thanks!
I found 29 instances before patching and 18 after - all in media / system / js which I did not rebuild.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29987.