Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#29980] - [4.0] Fix js ajax for pre update checker

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar degobbis
degobbis
5 Jul 2020

Summary of Changes

Fix js ajax for pre update checker

Testing Instructions

  • Install an extension
  • Go to joomla update
    [update 07.07.2020]
  • Click on Options on the right corner
  • Change Update Chanel to Custom Url
  • Change Minimum Stability to Development
  • Insert https://update.joomla.org/core/nightlies/next_major_list.xml as Custom URL than Save and close
  • Check for updates

Actual result BEFORE applying this Pull Request

Notice the pre update checker cant find the combat tag
All installed extensions show the flag: Missing Compatibility Tag

grafik

Expected result AFTER applying this Pull Request

The pre update checker can now find the combat tag (npm required)
All installed extensions without update server show the flag: Missing Compatibility Tag
All installed extensions with update server but without update block with a <targetplatform> tag for Joomla 4 show the flag: No
All installed extensions with update server and an update block with a <targetplatform> tag for Joomla 4 show the flag: Yes

grafik

avatar degobbis degobbis - open - 5 Jul 2020
avatar degobbis degobbis - change - 5 Jul 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2020
Category ⇒ JavaScript Repository NPM Change
avatar degobbis degobbis - change - 5 Jul 2020
Labels Added: NPM Resource Changed ?
avatar degobbis degobbis - change - 7 Jul 2020
The description was changed
avatar degobbis degobbis - edited - 7 Jul 2020
avatar degobbis
degobbis - comment - 7 Jul 2020

I have updated the test instructions because the Pre-Checker was not triggered in the default configuration.

avatar chmst chmst - test_item - 7 Jul 2020 - Tested successfully
avatar chmst
chmst - comment - 7 Jul 2020

I have tested this item ✅ successfully on f0f1cd1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29980.

avatar chmst
chmst - comment - 7 Jul 2020

screen shot 2020-07-07 at 20 05 28

Result after patch

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29980.

avatar degobbis degobbis - change - 8 Jul 2020
The description was changed
avatar degobbis degobbis - edited - 8 Jul 2020
avatar bonzani bonzani - test_item - 12 Jul 2020 - Tested successfully
avatar bonzani
bonzani - comment - 12 Jul 2020

I have tested this item ✅ successfully on d876f4c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29980.

avatar degobbis
degobbis - comment - 13 Jul 2020

RTC

avatar SharkyKZ SharkyKZ - change - 13 Jul 2020
Status Pending ⇒ Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 13 Jul 2020

RTC.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29980.

avatar wilsonge wilsonge - change - 19 Jul 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-07-19 16:31:16
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 19 Jul 2020
avatar wilsonge wilsonge - merge - 19 Jul 2020
avatar wilsonge
wilsonge - comment - 19 Jul 2020

Thanks!

Add a Comment

Login with GitHub to post a comment