Joomla! Issue Tracker | Joomla! CMS #29938

NPM Resource Changed ? ?

Fixed in Code Base
11 Jul 2020
Medium
Build: 4.0-dev
# 29938
Diff
brianteeman:fri2

Pending

Pending Hound Hound is busy sniffing around... Details

User tests: Successful: Unsuccessful:

brianteeman
3 Jul 2020

Pull Request for Issue #29366 by @mbabker .

All other changes are contained in the IFW server component.

809f487 3 Jul 2020

[4.0] IFW client js

brianteeman - open - 3 Jul 2020

brianteeman - change - 3 Jul 2020

Status

New

⇒

Pending

joomla-cms-bot - change - 3 Jul 2020

Category

⇒

JavaScript Repository NPM Change

8afb7dd 3 Jul 2020

hound

brianteeman - change - 3 Jul 2020

Labels

Added: NPM Resource Changed ?

ceford - comment - 4 Jul 2020

I can confirm the problem but can't test with Patchtester, I get this: 'There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation.'

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29938.}

zero-24 - comment - 4 Jul 2020

@ceford you have to use the pre build packages or run npm as js files have been changed

ceford - comment - 4 Jul 2020

Another thought has occurred to me: the drop down list offers a choice between Current Joomla Version and All Joomla Versions; what happens when Joomla 4 is released? I should imagine that Joomla 3.10 and Joomla 4 will overlap as current versions for two years. So 'Current' becomes ambiguous. Thanks for the tip zero-24 - one day I might master testing without the Patchtester.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29938.}

zero-24 - comment - 4 Jul 2020

I have not checked the details but I would expect current to be the version you have installed so current is working even with two parallel versions.

8b04509 4 Jul 2020

js code style that hound missed

mbabker - comment - 4 Jul 2020

Current is the version of Joomla you are actually using, not current as in the newest release of the software (i.e. "my site is currently using Joomla 3.9.whatever").

Quy - test_item - 4 Jul 2020 - Tested successfully

Quy - comment - 4 Jul 2020

I have tested this item ✅ successfully on 8b04509

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29938.}

jwaisner - test_item - 10 Jul 2020 - Tested successfully

jwaisner - comment - 10 Jul 2020

I have tested this item ✅ successfully on 8b04509

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29938.}

jwaisner - change - 10 Jul 2020

Status

Pending

⇒

Ready to Commit

jwaisner - comment - 10 Jul 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29938.}

richard67 - change - 11 Jul 2020

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2020-07-11 14:58:48
Closed_By		⇒	richard67
Labels	Added: ?

richard67 - close - 11 Jul 2020

richard67 - merge - 11 Jul 2020

richard67 - comment - 11 Jul 2020

Thanks!

brianteeman - comment - 11 Jul 2020

thanks

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#29938] - [4.0] IFW client js

Add a Comment