User tests: Successful: Unsuccessful:
This PR addresses multiple accessibility, consistency and usability issues with the featured icon in com_contacts.
After reports from webaim and checking with Bruce Lawson it is not safe to rely on a "title" attribute to provide the required text for assistive technology.
In this PR the text from the title is now present as a div instead of a title
The text did not indicate what the current featured status was so it has been changed and is not consistent with the published status icon
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_contact Language & Strings |
Category | Administration com_contact Language & Strings | ⇒ | Accessibility Administration com_contact Language & Strings |
I'm not sure I agree. The "error" could be the role. If this needs to be changed then it needs to be changed everywhere this pattern is used and I am sure the accessibility team had already checked it. Especially as the first use was over a year ago
If this needs to be changed then it needs to be changed everywhere this pattern is used...
No problem.... just a lot of PR's with aria-labelledby changing into aria-describedby
and I am sure the accessibility team had already checked it.
I am just copying he W3.org rules.
@chmst please join us in this discussion.
Whatever is correct I am happy to change. Just want the accessibility team to make a decision.
Personally I would merge this one and then they are all consistent and if necessary change them all in another pr
For reference there are multiple different uses of this pattern. Here it is used because there is no label on the link and I was following the advice of experts so here I think the role is the problem.
In some other cases such as in the list of available languages it is a description for an icon but has no aria
And finally it is used on the search field but there it is defiitely correctly using described by
@brianteeman someone started an issue on w3c/aria-practices#1034
I've seen other issues in w3c/aria-practices about aria-labelledby
, aria-describedby
and even about role="tooltip"
In other words.. using aria-labelledby
or aria-describedby
should be another discussion. Your PR copies the way J4 implemented tooltip. And that is fine.
I am going to test your PR
@hans2103 its kind of off-topic but the aria-practices site is regularly criticised by leading accessibility experts including members of wcag https://adrianroselli.com/2017/10/dont-use-aria-menu-roles-for-site-nav.html
I have tested this item
I have tested this item
My favorite source is the webaim where aria-describedby is used in sample code, but as @hans2103 wrote, it is not necessary what we must decide in this PR.
Status | Pending | ⇒ | Ready to Commit |
RTC
@brianteeman Please fix PHPCS errors reported by Drone here https://ci.joomla.org/joomla/joomla-cms/33631/1/9:
FILE: ...components/com_contact/src/Service/HTML/AdministratorService.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
126 | ERROR | [x] Line indented incorrectly; expected 1 tabs, found
| | 1
| | (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
127 | ERROR | [x] Opening brace indented incorrectly; expected 5
| | spaces, found 4
| | (PEAR.Functions.FunctionDeclaration.BraceIndent)
141 | ERROR | [x] Concat operator must be surrounded by a single
| | space
| | (Squiz.Strings.ConcatenationSpacing.PaddingFound)
150 | ERROR | [x] Closing brace indented incorrectly; expected 5
| | spaces, found 4. Note: the autofixer will convert
| | spaces to tabs
| | (Squiz.WhiteSpace.ScopeClosingBrace.Indent)
Labels |
Added:
?
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-05 20:41:11 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
@brianteeman
According to https://www.w3.org/TR/wai-aria-practices/#tooltip
Your pull request uses
aria-labelledby
instead ofaria-describedby
.Can you change this into
aria-describedby
?