Feeling Lucky
?
?
[#29927] - [4.0] Fix Vertical Tabs - The orientation parameter is ignored
- Fixed in Code Base
- 4 Jul 2020
- Medium
- Build: 4.0-dev
- # 29927
- Diff
- tassosm:fixTabsVerticalOrientation
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Although the Tabs CSS file includes styles for displaying tabs in a vertical orientation the UiTab class doesn't take into account the orientation parameter. The PR makes startTabSet() method read that property too.
Testing Instructions
Try to create vertical tabs using the code below:
use Joomla\CMS\HTML\HTMLHelper;
echo HTMLHelper::_('uitab.startTabSet', 'sections', ['orientation' => 'vertical']);
echo HTMLHelper::_('uitab.addTab', 'sections', 'tab1', 'Tab 1');
echo 'content of tab1';
echo HTMLHelper::_('uitab.endTab');
echo HTMLHelper::_('uitab.addTab', 'sections', 'tab2', 'Tab 2');
echo 'content of tab2';
echo HTMLHelper::_('uitab.endTab');
echo HTMLHelper::_('uitab.addTab', 'sections', 'tab3', 'Tab 3');
echo 'content of tab3';
echo HTMLHelper::_('uitab.endTab');
echo HTMLHelper::_('uitab.endTabSet');
Actual result BEFORE applying this Pull Request
The orientation param is ignored and the tabs are displayed horizontally
Expected result AFTER applying this Pull Request
With this PR tabs are correctly displayed vertically
Keep in mind that the styling doesn't look really nice to me but I am willing to check it with another PR.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
alikon
- comment
- 4 Jul 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29927.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 4 Jul 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29927.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-04 16:14:47 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
?
|
||
infograf768
- comment
- 4 Jul 2020
Tks.
I have tested this item✅ successfully on ae37d8b
I found a convenient place to test this was in the Privacy -> Capabilities page.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29927.