Feeling Lucky
?
?
[#29852] - [4.0] Move event listener from joomla-toolbar-button to button element
- Fixed in Code Base
- 30 Jun 2020
- Medium
- Build: 4.0-dev
- # 29852
- Diff
- SharkyKZ:j4/js/joomla-toolbar-button
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #29820.
Summary of Changes
Moves event listener from joomla-toolbar-button element to actual clickable button.
Testing Instructions
node build.js --compile-js required.
Go to any backend view containing toolbar buttons.
Click a couple of pixels below or above a button.
Actual result BEFORE applying this Pull Request
Button clicked.
Expected result AFTER applying this Pull Request
Button not clicked.
Also check that buttons continue to work properly.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
Quy
- comment
- 30 Jun 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29852.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 30 Jun 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29852.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-30 17:32:51 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 30 Jun 2020
Thanks!
Fedik
- comment
- 4 Jul 2020
It a styling issue, not JS, better fix would be correct CSS somehow,
Additionally:this.buttonElement may not exists, that will lead to another issue ;)
Just a warning :)
I have tested this item✅ successfully on c653e7f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29852.