? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
28 Jun 2020

s/cachable/cacheable in comment (I missed one!)

avatar PhilETaylor PhilETaylor - open - 28 Jun 2020
avatar PhilETaylor PhilETaylor - change - 28 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jun 2020
Category Front End Plugins
avatar brianteeman
brianteeman - comment - 28 Jun 2020

Could you please close this and add it to #29812

avatar PhilETaylor
PhilETaylor - comment - 28 Jun 2020

No because its totally unrelated.

In fact if you look this was reverted out of #29812 specifically to be its own issue, as you and others had already tested the large spelling PR I made.

This is a tiny comment change which is a typo and can be merged instantly. It has no knock on effects and refers to the caching in the browser of a redirect.

#29812 is about PHP Code and a legacy typo that has massive consequences to change and will hang around unmerged for months/years/forever

The two are totally unconnected.

avatar brianteeman
brianteeman - comment - 28 Jun 2020

and thats why we add descriptions such as - only effects a comment

avatar brianteeman brianteeman - test_item - 28 Jun 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Jun 2020

I have tested this item successfully on 2c7ec54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29813.

avatar PhilETaylor
PhilETaylor - comment - 28 Jun 2020

I'm sorry that " in comment" in the title AND description was missed by you...

avatar Quy Quy - test_item - 28 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 28 Jun 2020

I have tested this item successfully on 2c7ec54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29813.

avatar Quy Quy - change - 28 Jun 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 28 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29813.

avatar zero-24 zero-24 - change - 28 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-28 19:11:16
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 28 Jun 2020
avatar zero-24 zero-24 - merge - 28 Jun 2020
avatar zero-24
zero-24 - comment - 28 Jun 2020

Merged

Add a Comment

Login with GitHub to post a comment