Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#29812] - [4.0] Propose s/cachable/cacheable

? Success

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
28 Jun 2020

Summary of Changes

Proposing the fixing of the long term typo of cachable to be fixed in the new major series of Joomla 4

It shouldn't be a b/c break as its just a variable name but @HLeithner says

Only thing to consider is that this method is abstracted by 3rd party developer and we should check this before we make a b/c break. I don't know if we have property/option arrays with cachable in the code base.

Testing Instructions

TEST EVERYTHING ;-)

Actual result BEFORE applying this Pull Request

EVERYTHING Works

Expected result AFTER applying this Pull Request

EVERYTHING Works

Documentation Changes Required

Maybe a note in the https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4 ?

avatar PhilETaylor PhilETaylor - open - 28 Jun 2020
avatar PhilETaylor PhilETaylor - change - 28 Jun 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jun 2020
Category ⇒ Administration com_banners com_categories com_checkin com_config com_contact com_content com_cpanel com_csp com_fields com_finder com_installer com_joomlaupdate com_languages com_login com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates com_users com_workflow Front End
avatar PhilETaylor PhilETaylor - change - 28 Jun 2020
Labels Added: ?
avatar Razzo1987
Razzo1987 - comment - 17 Oct 2020

After apply the patch on this file remains cachable:

components/com_tags/src/Controller/DisplayController.php
components/com_finder/src/Controller/DisplayController.php
components/com_newsfeeds/src/Controller/DisplayController.php
components/com_privacy/src/Controller/DisplayController.php
components/com_users/src/Controller/DisplayController.php
components/com_content/src/Controller/DisplayController.php
components/com_wrapper/src/Controller/DisplayController.php
libraries/src/MVC/Controller/BaseController.php
libraries/vendor/joomla/application/src/WebApplicationInterface.php
libraries/vendor/joomla/application/src/AbstractWebApplication.php

I think the branch must be updated because you fix it

avatar ceford
ceford - comment - 18 Nov 2020

There are 107 instances in php files before applying the pr and 39 after. As this is a variable name it seems to me it may as well be all or nothing. Only where it occurs as $cachable.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29812.

avatar PhilETaylor PhilETaylor - change - 18 Nov 2020
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-11-18 13:08:55
Closed_By ⇒ PhilETaylor
avatar PhilETaylor PhilETaylor - close - 18 Nov 2020

Add a Comment

Login with GitHub to post a comment