NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
27 Jun 2020

Pull Request for Issue #29459 .

Summary of Changes

This is a bit as workaround, because Choices.js always auto-highlight first item in drop-down list.

Testing Instructions

Apply patch and run npm install,
And follow the steps from #29459 issue:

Create two custom modules with positions bubletopright and bubletopleft.
Create a third custom module with position bublebottomright

Actual result BEFORE applying this Pull Request

Not posible to create a module in new position - one of the other positions is selected all the time

Expected result AFTER applying this Pull Request

Posible to create the new third module in new position

avatar Fedik Fedik - open - 27 Jun 2020
avatar Fedik Fedik - change - 27 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jun 2020
Category JavaScript Repository NPM Change
cec2b3c 27 Jun 2020 avatar Fedik dog
avatar Fedik Fedik - change - 27 Jun 2020
Labels Added: NPM Resource Changed ?
e14fac3 27 Jun 2020 avatar Fedik dog
6af28f6 27 Jun 2020 avatar Fedik dog
1433354 27 Jun 2020 avatar Fedik dog
avatar chmst chmst - test_item - 27 Jun 2020 - Tested successfully
avatar chmst
chmst - comment - 27 Jun 2020

I have tested this item successfully on 1433354

I have tested successfully - but am no js expert. So just following the instructions without code inspect.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29793.

avatar Fedik
Fedik - comment - 27 Jun 2020

I have made feature request if someone interestings jshjohnson/Choices#874

avatar Quy Quy - test_item - 30 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 30 Jun 2020

I have tested this item successfully on 1433354


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29793.

avatar Quy Quy - change - 30 Jun 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29793.

avatar wilsonge wilsonge - change - 30 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-30 11:30:38
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 30 Jun 2020
avatar wilsonge wilsonge - merge - 30 Jun 2020
avatar wilsonge
wilsonge - comment - 30 Jun 2020

Thanks! Nice work!

Add a Comment

Login with GitHub to post a comment