User tests: Successful: Unsuccessful:
Pull Request for Issue #29759.
When closing the "Add module" modal, the "Cancel" button inside the modal should be clicked. In the second step, i.e. after we have selected the type of the module to be added and see the module form, this works. But in the first step, there is no "Cancel" button inside the modal, which leads to a JavaScript error being logged in the browser console.
After applying the patch, you need to run npm ci
to compile the JavaScript change.
An error message is shown in the console:
content.querySelector(clickTarget) is null --- admin-add_module.min.js
Note: The modal still closes correctly, so no functionality is broken. But the error appears and we don't want that.
No JS error should appear.
None
Ping @bembelimen as you implemented the original functionality and might see any caveats how this PR could break things.
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
It would have been helpful to mention that it needs to run npm for "compiling" the js. Not everybody knows that.
True, thank you! I added it to the description.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
?
NPM Resource Changed
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-24 08:48:44 |
Closed_By | ⇒ | wilsonge | |
Labels |
Thanks!
I have tested this item✅ successfully on 862b9f3
It would have been helpful to mention that it needs to run npm for "compiling" the js. Not everybody knows that.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29771.