NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
22 Jun 2020

Redo #23893 to fix conflicting files.

Summary of Changes

Add title attribute to action buttons.

It is not 100% accessible as stated in the previous PR, however, it is better than nothing.

Testing Instructions

Apply PR.
Run npm i.

Go to Media.
Hover an image/directory to display ... icon.
Click ... icon to display icons.
Hover an icon to show a title tip.

Actual result BEFORE applying this Pull Request

No title tip.

avatar Quy Quy - open - 22 Jun 2020
avatar Quy Quy - change - 22 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jun 2020
Category Administration com_media NPM Change
avatar Quy Quy - change - 22 Jun 2020
The description was changed
avatar Quy Quy - edited - 22 Jun 2020
avatar richard67 richard67 - test_item - 22 Jun 2020 - Tested successfully
avatar richard67
richard67 - comment - 22 Jun 2020

I have tested this item successfully on 9d96d07


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29760.

avatar jwaisner jwaisner - test_item - 22 Jun 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 22 Jun 2020

I have tested this item successfully on 9d96d07


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29760.

avatar jwaisner jwaisner - change - 22 Jun 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 22 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29760.

avatar richard67 richard67 - change - 22 Jun 2020
Labels Added: ? ? NPM Resource Changed
avatar wilsonge wilsonge - change - 29 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-29 21:47:12
Closed_By wilsonge
Labels
avatar wilsonge
wilsonge - comment - 29 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment