? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
21 Jun 2020

docblock changes only, can be merged on review

added missing @var for the extracted $vars from $displaydata

 * @var   string   $dirname         The directory name
 * @var   string   $addonBefore     The text to use in a bootstrap input group prepend
 * @var   string   $addonAfter      The text to use in a bootstrap input group append

Before this an IDE would show these in red (by default in phpStorm)

Screenshot 2020-06-21 at 22 04 16

avatar PhilETaylor PhilETaylor - open - 21 Jun 2020
avatar PhilETaylor PhilETaylor - change - 21 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jun 2020
Category Layout
avatar richard67 richard67 - test_item - 22 Jun 2020 - Tested successfully
avatar richard67
richard67 - comment - 22 Jun 2020

I have tested this item successfully on 51f38b6

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29752.

avatar Quy Quy - test_item - 22 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 22 Jun 2020

I have tested this item successfully on 51f38b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29752.

avatar Quy Quy - change - 22 Jun 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 22 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29752.

avatar richard67 richard67 - change - 22 Jun 2020
Labels Added: ? ?
avatar wilsonge wilsonge - change - 22 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-22 15:59:50
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 22 Jun 2020
avatar wilsonge wilsonge - merge - 22 Jun 2020
avatar wilsonge
wilsonge - comment - 22 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment