Feeling Lucky
?
[#29751] - [4.0] remove redundant code & general cleanup
- Fixed in Code Base
- 22 Jun 2020
- Medium
- Build: 4.0-dev
- # 29751
- Diff
- PhilETaylor:redundantcode
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
remove redundant code (and a todo)
$database is not used
added a \ to a fqdn to allow for IDE auto completion and cmd+click
Convert array to [] syntax
Testing Instructions
Turn on the debug mode to get the pgpDebugBar at the bottom - open it up to the queries page
Actual result BEFORE applying this Pull Request
Everything is logged fine
Expected result AFTER applying this Pull Request
Everything is logged fine - no change.
IDE can hover cmd+click full class
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-22 13:26:52 |
| Closed_By | ⇒ | wilsonge |
Merged on code review. One thing to note. As a general rule for future things can we leave out the array to
[]conversions in - it causes more merge conflicts than it's worth when trying to merge up 3.x into 4.x - it's something we should probably do after 3.x goes EOL for maintainability (In this specific PR the debug plugin has been entirely rewritten so everything is a conflict anyhow :D hence merging this one)Thanks!