[#29707] - [4.0] WebAuthn: Cannot take an administrative action after adding an authenticator
- Fixed in Code Base
- 22 Jun 2020
- Medium
- Build: 4.0-dev
- # 29707
- Diff
- nikosdion:fix/29697-webauthn-ui-inert
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
For example, after adding one authenticator you cannot edit its name or add another authenticator.
Pull Request for Issue #29697 .
Summary of Changes
Re-attaches the click event handlers after adding an authenticator
This bug is present since the original merge of the WebAuthn feature into Joomla 4. No, I did not contribute a broken feature. The code I had contributed was using ES5 and inline click handlers; it was working just fine. Before merging, Harald converted the ES5 to ES6 and replaced the inline click handlers to event handlers. However, after saving an Authenticator we are replacing the HTML of the #plg_system_webauthn-management-interface element with the one loaded from the server. With inline click handlers this worked fine. The new HTML had click handlers and all interface elements worked. After the conversion, Harald forgot to attach event handlers to the new HTML, therefore the interface was inert.
Testing Instructions
On an HTTPS site's backend edit your user account. Go to the WebAuthn tab.
Add a new authenticator.
Click on its Edit button.
Expected result
You can edit the authenticator's name.
Actual result
Nothing happens no matter how hard you click on that button.
Documentation Changes Required
None.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
With the Patch Tester I clicked Apply Patch and got this message:
Message
There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation.
Without the patch I see no WebAuthn tab in my Edit Profile form
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29707.
@ceford The patch tester is no good with Joomla 4 PRs that touch core JavaScript like mine. You have to go through the manual and long-winded process, including running composer install and npm ci. You will also need an HTTPS site as a prerequisite for using WebAuthn.
@richard67 Thanks. I thought these issues are caught by the Hound, not Drone. There's something to be said about complexity being the mother of bureaucracy and reduced productivity
@nikosdion I haven't invented it ;-)
I have tested this item
All works as expected now, frontend and admin console.
Only thing I noted, separate to this, is that when you delete all authenticators you dont get "No authenticators have been set up yet." back again, until you hard refresh the page.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29707.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29707.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29707.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-22 12:03:41 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@nikosdion Drone javascript-cs test complans about a missing semicolon in file
src/build/media_source/plg_system_webauthn/js/management.es6.js, line 426: https://ci.joomla.org/joomla/joomla-cms/33273/1/24.