[#29664] - Banner impressions exceeded by 1
- Fixed in Code Base
- 19 Jun 2020
- Medium
- Build: staging
- # 29664
- Diff
- SharkyKZ:j3/bug/banner-impressions
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #29651.
Summary of Changes
Fixes max banner impressions being exceeded by 1 impression.
Testing Instructions
Create a banner. Set Max. Impressions to 1.
Create a banner module.
Open a page containing the module.
Refresh the page a couple of times.
Expected result
Banner is shown once (on first load only).
Actual result
Banner is shown twice (on first load and after first refresh).
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29664.
This fixes Joomla 3.
The line in Joomla 4 is different, the original issue reported in Joomla 4, lets hope George is still bubbling these up.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29664.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29664.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-19 10:17:25 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks. I am indeed bubbling these up - I try and do it after each Joomla 3 release
Hmm, I hv the Expected result without Patch. Set Max. Impressions to 1.