? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
17 Jun 2020

Fixes #29653.

Summary of Changes

Corrects redirect after deleting content history version.

Testing Instructions

Create an article.
Edit and save it so a version history is saved.
Click Versions button in the toolbar.
Select the older version. Click Delete.

Expected result

Redirected back to a list containing remaining versions.

Actual result

Redirected to an empty page. PHP notices are shown:

Notice: Undefined offset: 1 in administrator\components\com_contenthistory\src\Model\HistoryModel.php on line 419
Notice: Undefined offset: 1 in administrator\components\com_contenthistory\tmpl\history\modal.php on line 29
Notice: Undefined offset: 1 in administrator\components\com_contenthistory\tmpl\history\modal.php on line 31

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 17 Jun 2020
avatar SharkyKZ SharkyKZ - change - 17 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jun 2020
Category Administration com_content com_contenthistory
avatar ChristineWk ChristineWk - test_item - 17 Jun 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 17 Jun 2020

I have tested this item successfully on 3517ff2

Message: "History version deleted".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29663.

avatar chmst chmst - test_item - 17 Jun 2020 - Tested successfully
avatar chmst
chmst - comment - 17 Jun 2020

I have tested this item successfully on 3517ff2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29663.

avatar Quy Quy - change - 17 Jun 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 17 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29663.

avatar wilsonge wilsonge - change - 20 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-20 00:57:14
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 20 Jun 2020
avatar wilsonge wilsonge - merge - 20 Jun 2020
avatar wilsonge
wilsonge - comment - 20 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment