[#29555] - [4.0] Duplicate queries when user has no contacts
- Fixed in Code Base
- 11 Jun 2020
- Medium
- Build: 4.0-dev
- # 29555
- Diff
- SharkyKZ:j4/query/plg-content-contact
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Fixes duplicate queries in Content - Contact plugin when author has no contacts assigned.
Testing Instructions
Create some articles
Go to com_content configuration.
Enable Link to Author's Contact Page option.
View article list/blog in frontend.
Expected result
No (or some, based on how many authors) duplicate queries in plugins\content\contact\contact.php.
Actual result
Many duplicates of this:
SELECT `contact`.`id` AS `contactid`,`contact`.`alias`,`contact`.`catid`,`contact`.`webpage`,`contact`.`email_to`
FROM `a400_contact_details` AS `contact`
WHERE `contact`.`published` = 1 AND `contact`.`user_id` = :createdby
ORDER BY `contact`.`id` DESC LIMIT 1
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
Scenario: One user only exists who is author of all articles. Option to link to his contact in articles is enabled, but there is no contact.
Without Patch: As many queries "SELECT contact.id AS contactid ..." as there are articles on the current page (in test: featured articles).
With patch: Only one.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29555.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29555.
| Labels |
Added:
?
?
|
||
Quy
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-11 13:05:42 |
| Closed_By | ⇒ | Quy | |
| Labels | |||
I have tested this item✅ successfully on 7ee0bea
Without the patch:
58 statements were executed, 22 of which were duplicates, 36 unique
4 copies of example.
With the patch:
55 statements were executed, 18 of which were duplicates, 37 unique
Example is unique.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29555.