? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 Jun 2020

Updating #23992 for workflow v3

Pull Request for Issue #29547

avatar brianteeman brianteeman - open - 9 Jun 2020
avatar brianteeman brianteeman - change - 9 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2020
Category Administration Language & Strings
avatar richard67
richard67 - comment - 9 Jun 2020

Harald has a holiday. Not sure if he can review soon. Maybe @bembelimen can?

Update: Maybe it was an automatic review request because of code ownership. Sorry for disturbing.

avatar Quy Quy - test_item - 9 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 9 Jun 2020

I have tested this item successfully on 30b842b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29554.

avatar richard67
richard67 - comment - 9 Jun 2020

Maybe I understand something wrong: I have applied the change of this PR, but I still see the untranslated strings when viewing a group's permission like described in issue #29547 .

Anyone can enlighten me?

avatar Quy
Quy - comment - 9 Jun 2020

PR is working for me.

29554

avatar richard67
richard67 - comment - 9 Jun 2020

@Quy Just by applying the new language string?

avatar Quy
Quy - comment - 9 Jun 2020

Yes just applying the PR.

avatar Quy
Quy - comment - 9 Jun 2020

Before PR:
29554-before

avatar richard67
richard67 - comment - 9 Jun 2020

Doesn't work here, I get mad. I mean the PR is right, no doubt, just I apply it and still see those language constants in the groups' permissions.

avatar Quy
Quy - comment - 9 Jun 2020

Sorry I don't know why it is not working for you.

avatar richard67
richard67 - comment - 9 Jun 2020

For me both the basic stage and the basic workflow are not translated, like it is shown in the screenshot in issue #29547 . Wait, let's update my 4.0-dev branch, it is missing last 10 commits.

avatar richard67
richard67 - comment - 9 Jun 2020

@Quy In users permissions all is fine here, only in groups permissions not. Sure you've checked groups and not users? Your screenshot doesn't show it.

avatar brianteeman brianteeman - change - 9 Jun 2020
Labels Added: ? ?
avatar Quy
Quy - comment - 9 Jun 2020

@richard67 Oops, you are correct.

avatar richard67
richard67 - comment - 9 Jun 2020

@Quy So we have dilemma: This PR here is correct because it fixes the one untranslated language constant in the users' permisson, but it doesn't solve the issue it refers to because that was talking about the two untranslated constants in the groups permission.

What to do now? Test this PR with success and reopen the issue?

avatar Quy
Quy - comment - 9 Jun 2020

Let's wait for Brian, Herald or JM to chime in.

avatar richard67
richard67 - comment - 9 Jun 2020

I think it's some PHP stuff that the groups permissons don't load that (sys) language file.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2020
Category Administration Language & Strings Administration com_users Language & Strings
avatar brianteeman
brianteeman - comment - 9 Jun 2020

super easy change ;)

avatar richard67
richard67 - comment - 9 Jun 2020

Yes, no brainer ;-)

avatar richard67 richard67 - test_item - 9 Jun 2020 - Tested successfully
avatar richard67
richard67 - comment - 9 Jun 2020

I have tested this item successfully on 46b3b23


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29554.

avatar Quy Quy - test_item - 9 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 9 Jun 2020

I have tested this item successfully on 46b3b23


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29554.

avatar Quy Quy - change - 9 Jun 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29554.

avatar infograf768 infograf768 - change - 10 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-10 08:27:01
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 10 Jun 2020
avatar infograf768 infograf768 - merge - 10 Jun 2020
avatar infograf768
infograf768 - comment - 10 Jun 2020

tks

avatar brianteeman
brianteeman - comment - 10 Jun 2020

Thx

Add a Comment

Login with GitHub to post a comment