? ?
avatar HLeithner
HLeithner
7 Jun 2020

image

What needs to be fixed

The "Webauthn" button is directly attached to the "Log In" button.

Why this should be fixed

Looks ugly?

avatar HLeithner HLeithner - open - 7 Jun 2020
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 Jun 2020
avatar brianteeman
brianteeman - comment - 7 Jun 2020
  1. you can have multiple buttons
  2. Not tested it myself but this was a screenshot showing that taken from #29454

image

avatar HLeithner
HLeithner - comment - 7 Jun 2020

That's the module not the com_user login view

avatar brianteeman
brianteeman - comment - 7 Jun 2020

Sorry I missed that in the title. The comment about multiple buttons is still valid though.

avatar nikosdion
nikosdion - comment - 7 Jun 2020

That should be something to be addressed in the output of com_users. You could add the mb-2 class on each extra button but please wait until #29454 is merged first to avoid conflicts and duplicate work.

avatar Quy
Quy - comment - 3 Sep 2020

Duplicate #29138 due to no control-group class for the frontend template.

29470

avatar ghost
ghost - comment - 21 Sep 2020

Label J4 Frontend Template?

avatar Quy Quy - change - 21 Sep 2020
Labels Added: ?
avatar Quy Quy - labeled - 21 Sep 2020
avatar infograf768
infograf768 - comment - 22 Sep 2020

Can't we just add a class for control-group?

diff --git a/templates/cassiopeia/scss/blocks/_form.scss b/templates/cassiopeia/scss/blocks/_form.scss
index ae587bc..adf4870 100644
--- a/templates/cassiopeia/scss/blocks/_form.scss
+++ b/templates/cassiopeia/scss/blocks/_form.scss
@@ -22,4 +22,8 @@
 }
 
+.control-group {
+  margin-top: .5rem;
+}
+
 .custom-select {
   max-width: $input-max-width;

It would also work for #29228 and #29138

avatar hans2103
hans2103 - comment - 22 Sep 2020

Or apply Lobotomized Owl selector

* + * {
  margin-top: .5em;
}
avatar infograf768
infograf768 - comment - 22 Sep 2020

My local owls protest strongly against lobotomization... ;)
bitingowl_small

avatar Quy
Quy - comment - 22 Sep 2020

Here is the history of this class.

Bootstrap 2: .control-group
Bootstrap 3/4: .form-group
Bootstrap 5: .mb-3

So instead of top margin it should be bottom margin to be consistent with Bootstrap?

avatar infograf768
infograf768 - comment - 22 Sep 2020

That will not work for the Submit buttons. #29228

avatar infograf768
infograf768 - comment - 22 Sep 2020

But we could use another css for these com_users buttons:

diff --git a/templates/cassiopeia/scss/blocks/_form.scss b/templates/cassiopeia/scss/blocks/_form.scss
index ae587bc..4c26844 100644
--- a/templates/cassiopeia/scss/blocks/_form.scss
+++ b/templates/cassiopeia/scss/blocks/_form.scss
@@ -113,2 +113,7 @@
   bottom: auto;
 }
+
+// com_users submit buttons
+[class^=com-users-] {
+  margin-top: .5rem;
+}
avatar Quy
Quy - comment - 22 Sep 2020

It will work because it is wrapped in a control-group.

register

avatar infograf768
infograf768 - comment - 23 Sep 2020

@Quy
You are right. Can you make patch?

avatar Quy
Quy - comment - 23 Sep 2020

@infograf768 There is a PR under the cassiopeia repo: joomla/cassiopeia#99

avatar Quy Quy - change - 29 Nov 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-11-29 15:05:53
Closed_By Quy
avatar Quy Quy - close - 29 Nov 2020
avatar Quy
Quy - comment - 29 Nov 2020

Please test PR #31520

Add a Comment

Login with GitHub to post a comment