[#29469] - [4.0] Improve user token plugin display in the profile page
- Fixed in Code Base
- 12 Jun 2020
- Medium
- Build: 4.0-dev
- # 29469
- Diff
- nikosdion:fix/29338-token-on-profile-page
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #29338 and #29337
cc @PhilETaylor @Quy
Summary of Changes
Changed the way the Joomla Token user profile field renders its information in the User Profile view page.
Testing Instructions
Set up a token and view – NOT edit! – your user profile in the public frontend of the site.
Expected result
Under Joomla API Token you get reasonable information e.g. what's your token and whether it's enabled.
Actual result
You get all sorts of misleading information. The token field displays the seed, not the token you need to use. The Active field displays 1 / 0 which great if you are a
This PR fixes this by displaying only the real token you need to use and whether it's enabled. Example:
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
No problem. But this does not fix the issue mentioned above. The form uses com_users.profile name both when editing and displaying so this won't work.
That's annoying so let's do it the same way I've been doing it in my own software: checking the layout in the request. Architecturally wrong but necessary as it seems
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29469.
Reset option is missing in edit mode.
Oh, seems I've missed that.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29469.
OK, this is ready for testing now.
I also fixed a bug I discovered about the token after I originally contributed this feature. If you saved the user object without passing user profile fields (or at least without passing the token profile fields) the token would be automatically reset. I had already fixed it in the FOF Token plugin which is where this core feature was forked from but forgot to file a PR to Joomla. Since I'm here fixing this feature I backported this bugfix from FOF as well.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29469.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29469.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29469.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-12 22:57:01 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks Nic!
The form is also altered when editing.