NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Ruud68
Ruud68
6 Jun 2020

Pull Request for Issue #27555

Summary of Changes

As suggested by @C-Lodder add additional click eventlistener in showon.js

Testing Instructions

Apply path, and run npm i to rebuild JavaScript files with this PR

Add config form field type radio with class "switcher btn-group btn-group-yesno"
Add an additional field that has a shownon dependency on the radio fiels

Expected result

clicking yes should show the additional field, no should hide the additional fields

Actual result

without this change, the showon functionality would not work on this radio field. Omitting the "btn-group btn-groupyesno" would fix that but then the same config file would break Joomla 3.x showon behavior.

Documentation Changes Required

None

Special Thanks to

@C-Lodder for coming up with the solution and everybody in advance for testing this PR

avatar Ruud68 Ruud68 - open - 6 Jun 2020
avatar Ruud68 Ruud68 - change - 6 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2020
Category JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 6 Jun 2020

Hint for testers: It needs to run npm to compile the js. @Ruud68 could you add a corresponding hint to your testing instructions? Testers would find it more easily there than here.

avatar Ruud68 Ruud68 - change - 6 Jun 2020
The description was changed
avatar Ruud68 Ruud68 - edited - 6 Jun 2020
avatar Ruud68
Ruud68 - comment - 6 Jun 2020

Hint for testers: It needs to run npm to compile the js. @Ruud68 could you add a corresponding hint to your testing instructions? Testers would find it more easily there than here.

Take it this now doesn't work anymore with the patchtester? Anyway, added a hint. my guess is that everybody who responded in the issue knows what to to and can test or has his own test case.

avatar richard67
richard67 - comment - 6 Jun 2020

@Ruud68 The latest beta of patchterster for J4 has the CI server option switched off because there were problems with it, and so it works again like the old PT 3, i.e. it needs npm for (s)css and js PRs.

avatar richard67 richard67 - test_item - 6 Jun 2020 - Tested successfully
avatar richard67
richard67 - comment - 6 Jun 2020

I have tested this item successfully on c378d3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29462.

avatar C-Lodder C-Lodder - test_item - 6 Jun 2020 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 6 Jun 2020

I have tested this item successfully on c378d3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29462.

avatar richard67 richard67 - change - 6 Jun 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 6 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29462.

avatar richard67 richard67 - change - 6 Jun 2020
Labels Added: ? ? NPM Resource Changed
avatar richard67
richard67 - comment - 6 Jun 2020

@Ruud68 Sometimes things can happen fast here ;-)

avatar Ruud68
Ruud68 - comment - 6 Jun 2020

Thanks all for testing!

avatar richard67
richard67 - comment - 6 Jun 2020

Now it just needs someone to merge .. ping @wilsonge ;-)

avatar richard67
richard67 - comment - 6 Jun 2020

I could if I was not one of the testers.

avatar C-Lodder
C-Lodder - comment - 6 Jun 2020

He's busy playing poker with me

avatar richard67
richard67 - comment - 6 Jun 2020

@C-Lodder Leave him a few quids left so he doesn't jump from a bridge when you are ready with him ... we still need him for a while as release lead ;-)

avatar wilsonge
wilsonge - comment - 6 Jun 2020

@C-Lodder you need to stop checking github on your stag night ;) also i'd stop loosing so hard too :D

avatar wilsonge wilsonge - change - 6 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-06 18:21:52
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 6 Jun 2020
avatar wilsonge wilsonge - merge - 6 Jun 2020
avatar wilsonge
wilsonge - comment - 6 Jun 2020

Thanks!

avatar ashishsinghjmd
ashishsinghjmd - comment - 22 Jul 2020

I tried the solution given above but a new issue found that in J4 if i use class "switcher btn-group btn-group-yesno" there are two label displayed.

Here is my Field:


Disable
Enable

2020-07-23_04-55-49

i think the field name displayed two times, as i tried removing label and description from field too.
is there any Solution or fix for that?

Thanks

Add a Comment

Login with GitHub to post a comment