NPM Resource Changed ? ? Pending
Pull Request for # 29436

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
5 Jun 2020

Fixes #29436.

Summary of Changes

Loads jQuery for treeselectmenu.js.

Testing Instructions

Depending on whether jQuery is loaded elsewhere you may not be able to reproduce the issue. Should be reproducible on a clean installation with debug disabled.

Edit a menu item.
In Module Assignments tab click on a module.
In the modal go to Menu Assignment tab.
In Module Assignment field select Only on the pages selected or On all pages except those selected.
Click on All and None buttons to change selected items.

Expected result

Items selected/unselected.

Actual result

Nothing happens, JS error is generated:

ReferenceError: jQuery is not defined treeselectmenu.min.js:1:1

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 5 Jun 2020
avatar SharkyKZ SharkyKZ - change - 5 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jun 2020
Category Administration com_menus com_modules Repository NPM Change
avatar SharkyKZ SharkyKZ - change - 5 Jun 2020
Rel_Number 29436
Relation Type Pull Request for
Labels Added: ? NPM Resource Changed
avatar Quy Quy - test_item - 5 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 5 Jun 2020

I have tested this item successfully on 03de374


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29447.

avatar C-Lodder C-Lodder - test_item - 6 Jun 2020 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 6 Jun 2020

I have tested this item successfully on 03de374


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29447.

avatar SharkyKZ SharkyKZ - change - 6 Jun 2020
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 6 Jun 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29447.

avatar HLeithner HLeithner - change - 6 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-06 08:25:29
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 6 Jun 2020
avatar HLeithner HLeithner - merge - 6 Jun 2020
avatar HLeithner
HLeithner - comment - 6 Jun 2020

Thanks

Add a Comment

Login with GitHub to post a comment