[#29431] - [4.0] Fix useless red class when unpublishing Content Language
- Fixed in Code Base
- 5 Jun 2020
- Low
- Build: 4.0-dev
- # 29431
- Diff
- infograf768:4.0_red_class
User tests: Successful: Unsuccessful:
Summary of Changes
As title says. That class has not been used for ages.
Testing Instructions
Create a content language. Unpublish it.
EDIT: small change in message to be more clear in English.
Can be merged on review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
a site language that also has to be was wrong. I used should have which may not be good english but reflects the real sense.
should have an assigned ? should be assigned a ?
Better suggestion?
Your original comment says there is no change in the message
yes, i forgot.
please, for once, be positive.
I'm not sure what you mean by "also has to be" is wrong so its hard to be exact but if I have guessed correctly then it should be
"should have an assigned "
As its a definitive statement - ie it wont work if you dont do this then it would be better to use the word "must"
"must have an assigned"
| Labels |
Added:
?
?
|
||
English corrected
I have tested this item
Updated language strings look good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29431.
| Priority | Medium | ⇒ | Low |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29431.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29431.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-05 21:49:02 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I am fine with removing the unused class but you have also changed the string. So the message has changed and it no longer makes sense in English.